From patchwork Wed Apr 15 14:48:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6221161 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C07879F313 for ; Wed, 15 Apr 2015 14:48:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C3B3C202A1 for ; Wed, 15 Apr 2015 14:48:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D12F52025A for ; Wed, 15 Apr 2015 14:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbbDOOsY (ORCPT ); Wed, 15 Apr 2015 10:48:24 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:34257 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbbDOOsW (ORCPT ); Wed, 15 Apr 2015 10:48:22 -0400 Received: by ykft189 with SMTP id t189so1510938ykf.1 for ; Wed, 15 Apr 2015 07:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=baddwInZ9+3L/GUa+8jcjVRJSFRVvwg83xfDWTaPxuk=; b=OY7ZcoIroM/Ky0ZXywKyTrtVAgYWstJOB7RSIVkKX+WH6u2lwD0pu4eqHA06b64rfz R7lPKU81btkSIfieG9455Q6EI86Cn3c8khzeMQCjVcASWyzzDSQ0aQEhA6lWa94udwT6 kiF0s9AXEkZjdbvD2zNylkZiHEwsHxCR7sVnYcAI9WiUFmrqFCjbT4PSVFQgkS94wK29 uK2al9z6KTcPZ+vlpfqt3nfJYbJ+BLfScDxq1X48QUeXw3sr7qDWc3i+FgPV3sZG+kUQ Hm9RufTKtn2bPAwc6/eJ/9S6KYO8PDT1kelBaQmaUHZ7WWasxAYMY3EAsuGLg4GwHtBR Zu1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=baddwInZ9+3L/GUa+8jcjVRJSFRVvwg83xfDWTaPxuk=; b=XSuFjfb2UlHzt931n0S0jfK2Ok3lynW5237a3sw8GZbVdbXqf5dTRiTvDyHevu0HqF CdnV7Ml6vgLuOfb6NwoCfK6iJpqeBOPavMpXClO1UR3kn+6r0EY58tWtr4HVkMLbdhqb s07lJGaOdgFM9tnpDt3TNrL4DGoqoETJ5hGQ1TBhMKuDEsN42XaB7oPJNk152lNpy7mO 6US/gHpXiUm+3KVuP3+bO2Ey0QPmbU6PaBx4WzNTZBxbI6u1dq1W2EEls8p8LftXv8LC nAtx/XeXd/yxLHxR5dGjwhBDnCTA/BfRKMgEBjj7BjHYt7GIIl97Yvd2MxDXiAFiunis RXUg== X-Gm-Message-State: ALoCoQlAOJQaS26huDmc+QI+A2TEuUrz00ZtzkzGGDNICCH+mDz0T9FvM8HiPcDoMLj3uXQM23c5 X-Received: by 10.42.207.206 with SMTP id fz14mr32011858icb.34.1429109302125; Wed, 15 Apr 2015 07:48:22 -0700 (PDT) Received: from google.com ([69.71.1.1]) by mx.google.com with ESMTPSA id yt7sm9440925igb.7.2015.04.15.07.48.21 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 15 Apr 2015 07:48:21 -0700 (PDT) Date: Wed, 15 Apr 2015 09:48:19 -0500 From: Bjorn Helgaas To: Tony Luck Cc: "linux-pci@vger.kernel.org" , linux-acpi Subject: Re: [PATCH v1 2/4] PCI: Mark invalid BARs as unassigned Message-ID: <20150415144819.GD19151@google.com> References: <20150312173201.1052.28341.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150312173533.1052.46464.stgit@bhelgaas-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FSL_HELO_FAKE, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 14, 2015 at 04:57:06PM -0700, Tony Luck wrote: > On Tue, Apr 14, 2015 at 4:30 PM, Bjorn Helgaas wrote: > > Thanks for the report, and sorry for breaking you. I hate to ask for > > more after all your work already, but would you mind collecting logs > > with "ignore_loglevel"? We only print the BAR information at > > KERN_DEBUG, so it doesn't make it to the console unless you use > > ignore_loglevel. > > > > I don't really see how the mptsas device at 83:00.0 worked before; > > ACPI didn't tell us about any MMIO apertures in the PCI1 host bridge. > > But I'll look closer. > > Attached logs with ignore_loglevel Thanks, Tony. Can you try with the attached debug patch (old kernel or new, it doesn't matter)? We think the host bridge apertures are (note that we didn't find an MMIO aperture): ACPI: PCI Root Bridge [PCI1] (domain 0000 [bus 80-ff]) pci_bus 0000:80: root bus resource [io 0x9000-0xfffe] pci_bus 0000:80: root bus resource [bus 80-ff] but BIOS set up MMIO windows on the bridges at 80:01.0 and 80:05.0, and it assigned space for igb and mptsas BARs below those bridges: pci 0000:80:01.0: PCI bridge to [bus 81] pci 0000:80:01.0: bridge window [mem 0xa0100000-0xa01fffff] pci 0000:81:00.0: reg 0x10: [mem 0xa0160000-0xa017ffff] pci 0000:81:00.1: reg 0x10: [mem 0xa0120000-0xa013ffff] pci 0000:80:05.0: PCI bridge to [bus 83] pci 0000:80:05.0: bridge window [mem 0xa0000000-0xa00fffff] pci 0000:83:00.0: reg 0x14: [mem 0xa0010000-0xa0013fff 64bit] Prior to c770cb4cb505, we complained about the PCI bridge windows not being inside a host bridge window, but we enabled the igb and mptsas devices anyway. After c770cb4cb505, we don't enable them (you reported that your disk is broken, and I think those two NICs are also broken). I don't know whether the BIOS failed to tell us about the MMIO aperture, or it did tell us and we parsed the _CRS info incorrectly. Bjorn --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 48cc65705db4..9e419c5a3d43 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -276,6 +276,12 @@ static acpi_status add_window(struct acpi_resource *res, void *data) unsigned long flags, offset = 0; struct resource *root; + /* ACPI_RESOURCE_TYPE_IRQ etc. */ + printk("host bridge resource %02d length %#02x\n", res->type, + res->length); + print_hex_dump(KERN_INFO, " : ", DUMP_PREFIX_OFFSET, 16, 1, + &res->data, res->length, 0); + /* Return AE_OK for non-window resources to keep scanning for more */ status = resource_to_window(res, &addr); if (!ACPI_SUCCESS(status))