From patchwork Mon Jun 29 09:17:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Fleming X-Patchwork-Id: 6687561 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4B0E8C05AC for ; Mon, 29 Jun 2015 09:17:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 768A720553 for ; Mon, 29 Jun 2015 09:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 843B320546 for ; Mon, 29 Jun 2015 09:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbbF2JRq (ORCPT ); Mon, 29 Jun 2015 05:17:46 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:36697 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbbF2JRo (ORCPT ); Mon, 29 Jun 2015 05:17:44 -0400 Received: by wguu7 with SMTP id u7so135700164wgu.3 for ; Mon, 29 Jun 2015 02:17:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=VNxaGHJmNGeqmpnqt/NJjqUq7/tH6oUFMmk1Fo2J/t0=; b=TR1XYGJeXvqHvRXcogiIMYMGgV9aWEFyJtTtE+WMGd83yYdc0H1pu0CMWaO25XpkdA NK3t6QoyuWVooAYiC9638hI69fmjYVSl1ZolY4SiCPPM8M0gjvFEiU+tYss7K5Zc6+px 5eDeNB9pv2wc6j8zAAgzZ5J92BNYsMi7N6ksX7MzHHPG0ANHX/6vVHEaPRABA7C8MRDf njij+VmZCGyN9A+G66kB5qo4OFBAigHWuEccvFKCYkksGqCvOR89dyr8uikePVDtaX4i gIikPVBWns13+XYoZExCjKHx/xGH1zG0XmaSDSRkPsWRqjySODhYlQFGaM9Qz7/K5qcX u4fA== X-Gm-Message-State: ALoCoQmP/jwR1x0eC9EE+TpoGMgVsY4YaB7m2bQJs4x/zu4eJCzNFRLWeB4FNFcDvFfKs4eAF81K X-Received: by 10.194.75.132 with SMTP id c4mr25616854wjw.80.1435569463102; Mon, 29 Jun 2015 02:17:43 -0700 (PDT) Received: from localhost ([90.216.251.237]) by mx.google.com with ESMTPSA id f3sm11163879wiz.13.2015.06.29.02.17.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 02:17:42 -0700 (PDT) Date: Mon, 29 Jun 2015 10:17:40 +0100 From: Matt Fleming To: Tom Yan Cc: linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org, Josh Triplett , Matthew Garrett Subject: Re: lower log level of efi-bgrt / handle status 0 Message-ID: <20150629091740.GD28334@codeblueprint.co.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 29 Jun, at 01:10:52AM, Tom Yan wrote: > My motherboard is ASUS H87-PRO which has UEFI BIOS. The kernel gives > the following error on every boot: > > Ignoring BGRT: invalid status 0 (expected 1) > > This happens when the "Boot Logo" BIOS option is set to "Auto" (AND > using a PCI-E display card, IIRC). According to the mobo's manual, > "Auto" means: > > "Automatically adjust the boot logo size according to Windows requirements." > > while the error will be gone if I set it to "Full Screen" (which makes > the boot logo look huge and ugly) or "Disabled" instead. > > The thing is nothing really goes wrong when I choose "Auto" except > from keep seeing that error. So could you make it accept/handle status > 0, or at least lower the log level of messages in efi-bgrt? I can see > that all of them make use of pr_err() and I wonder how important is > this BGRT thing. The rest of the error messages are quite important because they signal that the BGRT is somehow invalid, even though the firmware thinks it *is* valid. They are intended to catch buggy firmware and aid kernel developers in debugging. However, it probably does make sense to drop the pr_err() for ->status being zero though, because the firmware is explicitly telling us "The BGRT image is not being displayed". Josh, Matthew? Can you think of a reason that something like this wouldn't make sense? diff --git a/arch/x86/platform/efi/efi-bgrt.c b/arch/x86/platform/efi/efi-bgrt.c index d7f997f7c26d..480f3911228e 100644 --- a/arch/x86/platform/efi/efi-bgrt.c +++ b/arch/x86/platform/efi/efi-bgrt.c @@ -51,8 +51,8 @@ void __init efi_bgrt_init(void) return; } if (bgrt_tab->status != 1) { - pr_err("Ignoring BGRT: invalid status %u (expected 1)\n", - bgrt_tab->status); + pr_debug("Ignoring BGRT: invalid status %u (expected 1)\n", + bgrt_tab->status); return; } if (bgrt_tab->image_type != 0) {