diff mbox

New Surface 3 (atom x7) having problems with ACPI regions

Message ID 20150910073556.GA6863@aaronlu.sh.intel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Aaron Lu Sept. 10, 2015, 7:35 a.m. UTC 
On Thu, Sep 10, 2015 at 11:46:50AM +0800, Aaron Lu wrote:
> I'm not so sure of the below part:
> "
> The failure of executing the _STA control method will cause the device
> node not having the acpi_device structure created and then in the SPI
> ACPI enumerate function acpi_spi_add_device, it will not be created and
> used.
> "

With the above said, I wonder if the following patch which ignores the
error return of the _STA and set status to 0 makes any difference?


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bastien Nocera Sept. 17, 2015, 12:41 p.m. UTC | #1 
On Thu, 2015-09-10 at 15:35 +0800, Aaron Lu wrote:
> On Thu, Sep 10, 2015 at 11:46:50AM +0800, Aaron Lu wrote:
> > I'm not so sure of the below part:
> > "
> > The failure of executing the _STA control method will cause the
> > device
> > node not having the acpi_device structure created and then in the
> > SPI
> > ACPI enumerate function acpi_spi_add_device, it will not be created
> > and
> > used.
> > "
> 
> With the above said, I wonder if the following patch which ignores
> the
> error return of the _STA and set status to 0 makes any difference?

For the lurkers on the list, the discussion is happening in bugzilla
now, and the aforementioned patch didn't make a difference:
https://bugzilla.kernel.org/show_bug.cgi?id=104291

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index ec256352f423..418c8a7cec91 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -2293,7 +2293,7 @@  static int acpi_bus_type_and_status(acpi_handle handle, int *type,
 		*type = ACPI_BUS_TYPE_DEVICE;
 		status = acpi_bus_get_status_handle(handle, sta);
 		if (ACPI_FAILURE(status))
-			return -ENODEV;
+			*sta = 0;
 		break;
 	case ACPI_TYPE_PROCESSOR:
 		*type = ACPI_BUS_TYPE_PROCESSOR;