| Message ID | 20151022195259.GC24439@mwanda (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On 22 October 2015 at 15:52, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need > it to be signed. > > Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c > index 0bbf84b..2ed5516 100644 > --- a/drivers/acpi/cppc_acpi.c > +++ b/drivers/acpi/cppc_acpi.c > @@ -302,7 +302,7 @@ err_ret: > } > EXPORT_SYMBOL_GPL(acpi_get_psd_map); > > -static int register_pcc_channel(unsigned pcc_subspace_idx) > +static int register_pcc_channel(int pcc_subspace_idx) > { > struct acpi_pcct_subspace *cppc_ss; > unsigned int len; Acked-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> Thanks, Ashwin. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, October 23, 2015 04:45:09 AM Ashwin Chaugule wrote: > On 22 October 2015 at 15:52, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need > > it to be signed. > > > > Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC') > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c > > index 0bbf84b..2ed5516 100644 > > --- a/drivers/acpi/cppc_acpi.c > > +++ b/drivers/acpi/cppc_acpi.c > > @@ -302,7 +302,7 @@ err_ret: > > } > > EXPORT_SYMBOL_GPL(acpi_get_psd_map); > > > > -static int register_pcc_channel(unsigned pcc_subspace_idx) > > +static int register_pcc_channel(int pcc_subspace_idx) > > { > > struct acpi_pcct_subspace *cppc_ss; > > unsigned int len; > > Acked-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> Applied, thanks! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 0bbf84b..2ed5516 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -302,7 +302,7 @@ err_ret: } EXPORT_SYMBOL_GPL(acpi_get_psd_map); -static int register_pcc_channel(unsigned pcc_subspace_idx) +static int register_pcc_channel(int pcc_subspace_idx) { struct acpi_pcct_subspace *cppc_ss; unsigned int len;
The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need it to be signed. Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html