From patchwork Mon Mar 7 10:19:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Bainbridge X-Patchwork-Id: 8518291 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 28CF3C0553 for ; Mon, 7 Mar 2016 10:19:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2556320138 for ; Mon, 7 Mar 2016 10:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D3E220114 for ; Mon, 7 Mar 2016 10:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbcCGKTK (ORCPT ); Mon, 7 Mar 2016 05:19:10 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:34819 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbcCGKTJ (ORCPT ); Mon, 7 Mar 2016 05:19:09 -0500 Received: by mail-wm0-f49.google.com with SMTP id l68so78536744wml.0; Mon, 07 Mar 2016 02:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v1cm+WqzPqf+xDtyFhEabHcjwiwHj4OeIZpVctLZRB4=; b=DcIftJ5TDBPEyqihRS1cTsXRsNK+dWuhWFPGReAKMtMtuervm0XlUFztn0G4f2AwAp WUTA9dQvBvLJnkI9UO1F8Ji+oeifhRRtgsXSWdobcXfELEXeM5h1G1oLrdbjbnTls/Bu ql+ccyYNd4gYlCf65wntmVOUSW1xl9cHlFHJkuboDadyT2JbGQ4m+bFncGywK8veI0oC BwwEsV03cledKg4AYSu+/wd3cn7H0i3lSZ4JN8JGFV2mgiUF9yXNFwL6jvPvyDi7i99o X+6LCqCZtAI1oeN4YdkfmBgsm5tt3mhOKvfpj2YrHWxf+GDYdZQfkrOIM6BcnJgXuxbw gX9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v1cm+WqzPqf+xDtyFhEabHcjwiwHj4OeIZpVctLZRB4=; b=OUQl6gKS2XXTa+fU/0gx7C8owoRiRpP/+QEI8cz3hXz639qc0HN1Cp4eyv7Pj0elpc 2eLU3hQ6YbyCZMyOt3VLUUpJVB9UHYt39vEa6MFpTg0L9N119EtOaCqdLvjTQA6u8Lus 4wJHkllo50dV/2pD5uP6CBHszPUq1OmuNSrTMgXgF8wVrcZAmW4KsOs/JU5wnIEnDC2B RrhG7HVeWJFxjCaq96W3kYGz0JTRuXWpli6saCwN6+RHMYbsb1+IUswS+KKXHWDssCmu F8vk11B+xTcTca0pe6RauqeHdEeYddx3ocaNqFTEgPOf4xlK3M5ad9mf7ifyIPyFd3XZ mkQw== X-Gm-Message-State: AD7BkJLdpdj5wkLgJDmCEaxQeeK2UnEKyIx6n9TnsL2JdshHE9zEeA+WrSH2lRIzEZjQAQ== X-Received: by 10.28.135.4 with SMTP id j4mr12560674wmd.80.1457345947591; Mon, 07 Mar 2016 02:19:07 -0800 (PST) Received: from localhost (cpc5-sgyl32-2-0-cust224.sgyl.cable.virginm.net. [94.174.200.225]) by smtp.gmail.com with ESMTPSA id p189sm13013773wmb.7.2016.03.07.02.19.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2016 02:19:06 -0800 (PST) Date: Mon, 7 Mar 2016 10:19:04 +0000 From: Chris Bainbridge To: "Zheng, Lv" Cc: "Moore, Robert" , "Wysocki, Rafael J" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPICA: Events: Execute some _REG methods in early boot Message-ID: <20160307101904.GA4417@localhost> References: <20160227190828.GA4751@localhost> <1457190715-5851-1-git-send-email-chris.bainbridge@gmail.com> <1AE640813FDE7649BE1B193DEA596E883BB608C0@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB608C0@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Mar 07, 2016 at 06:36:05AM +0000, Zheng, Lv wrote: > Hi, > > First of all, why don't you respond on the kernel bugzilla? > Posting a fix here directly without communication doesn't look like a constructive help but more like a destructive attack to me. Sorry if it appears to be an attack. It wasn't meant that way. I was under the impression that email is the preferred means of communication for kernel development. I'm not sure whether other developers actively monitor bugzilla reports (some do, but bug trackers are often graveyards for bug reports and it's easy for communications to be missed). > As I said in the previous reply, this is the known issue and can be fixed by applying the whole series. > Especially this commit: > https://patchwork.kernel.org/patch/8241421/ > That's why I asked you to test again by applying the whole series. > And that's why after having not seen your response for so long time, we prepared a test branch and was waiting for your response. I already replied 9 days ago: https://lkml.org/lkml/2016/2/27/164 The suggested patch did not fix the issue and the patch series did not apply cleanly. (btw I'm not paid for this work so I tend to handle it in batches when I have spare time, which is why you may see replies delayed to weekends etc.) > You need to post acpidump there to have the issue root caused so that more accurate fix can be generated. I already sent an acpidump for this system to you and Robert (email 3rd Feb). > The above fix looks hackish to me. > IMO, if you want to stop regressions that are triggered by this commit. > A simpler and proper way would be to move acpi_gbl_reg_method_enabled = TRUE to the end of acpi_load_tables(). > So that when the order of table loading and ECDT probing is corrected, the correct logic can still apply. > > I don't have ECDT platforms in hand to confirm. > Can you help to just give it a try? Yes the fix may be hackish, but it served the purpose of correctly identifying the bug. Your suggestion works fine, for reference the tested patch was: With this patch applied the ODEBUG errors do not occur. Thanks. --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c index 278666e39563..9136d7250022 100644 --- a/drivers/acpi/acpica/tbxfload.c +++ b/drivers/acpi/acpica/tbxfload.c @@ -83,6 +83,7 @@ acpi_status __init acpi_load_tables(void) "While loading namespace from ACPI tables")); } + acpi_gbl_reg_methods_enabled = TRUE; return_ACPI_STATUS(status); } diff --git a/drivers/acpi/acpica/utxfinit.c b/drivers/acpi/acpica/utxfinit.c index 721b87cce908..2c0491038068 100644 --- a/drivers/acpi/acpica/utxfinit.c +++ b/drivers/acpi/acpica/utxfinit.c @@ -267,7 +267,6 @@ acpi_status __init acpi_initialize_objects(u32 flags) * initialized, even if they contain executable AML (see the call to * acpi_ns_initialize_objects below). */ - acpi_gbl_reg_methods_enabled = TRUE; if (!(flags & ACPI_NO_ADDRESS_SPACE_INIT)) { ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "[Init] Executing _REG OpRegion methods\n"));