diff mbox

Fix for Dell Latitude 3350 ethernet not working.

Message ID 20161112032914.hg24zqqlkwirxx7z@hotbox
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Michael Pobega Nov. 12, 2016, 3:29 a.m. UTC
The Dell Latitude 3350's ethernet card attempts to use a reserved IRQ (18),
resulting in ACPI being unable to enable the ethernet.

This patch forces a specific _REV (ACPI revision) value as a workaround
to allow the Dell Latitude 3350's board to work correctly.

The approach is similar to 18d78b64fddc11eb336f01e46ad3303a3f55d039

Signed-off-by: Michael Pobega <mpobega@neverware.com>
---
 drivers/acpi/blacklist.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Rafael J. Wysocki Nov. 24, 2016, 1:28 a.m. UTC | #1
On Friday, November 11, 2016 10:29:14 PM Michael Pobega wrote:
> The Dell Latitude 3350's ethernet card attempts to use a reserved IRQ (18),
> resulting in ACPI being unable to enable the ethernet.
> 
> This patch forces a specific _REV (ACPI revision) value as a workaround
> to allow the Dell Latitude 3350's board to work correctly.
> 
> The approach is similar to 18d78b64fddc11eb336f01e46ad3303a3f55d039
> 
> Signed-off-by: Michael Pobega <mpobega@neverware.com>
> ---
>  drivers/acpi/blacklist.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index bdc67ba..05cd61f 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -160,6 +160,18 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = {
>  		      DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9343"),
>  		},
>  	},
> +	/*
> +	 * Resolves a quirk with the Dell Latitude 3350 that
> +	 * causes the ethernet adapter to not function.
> +	 */
> +	{
> +	 .callback = dmi_enable_rev_override,
> +	 .ident = "DELL Latitude 3350",
> +	 .matches = {
> +		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
> +		},
> +	},
>  #endif
>  	{}
>  };
> 

Applied, with edited changelog.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index bdc67ba..05cd61f 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -160,6 +160,18 @@  static struct dmi_system_id acpi_rev_dmi_table[] __initdata = {
 		      DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9343"),
 		},
 	},
+	/*
+	 * Resolves a quirk with the Dell Latitude 3350 that
+	 * causes the ethernet adapter to not function.
+	 */
+	{
+	 .callback = dmi_enable_rev_override,
+	 .ident = "DELL Latitude 3350",
+	 .matches = {
+		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
+		},
+	},
 #endif
 	{}
 };