| Message ID | 20161202174247.141284-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Fri, Dec 2, 2016 at 6:42 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There is no need to override the error code returned by kstrtoul(). > Propagate it directly to the caller. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Both this and the [2/2] applied. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 4d8f2cd..35230cd 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -181,9 +181,7 @@ void acpi_os_vprintf(const char *fmt, va_list args) static unsigned long acpi_rsdp; static int __init setup_acpi_rsdp(char *arg) { - if (kstrtoul(arg, 16, &acpi_rsdp)) - return -EINVAL; - return 0; + return kstrtoul(arg, 16, &acpi_rsdp); } early_param("acpi_rsdp", setup_acpi_rsdp); #endif
There is no need to override the error code returned by kstrtoul(). Propagate it directly to the caller. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/osl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)