| Message ID | 20170123205008.10065-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Christophe, On 2017/1/24 4:50, Christophe JAILLET wrote: > If 'platform_device_alloc()' returns NULL, the current code returns > 0, which means success. Return -ENOMEM instead. > > Fixes: 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation") > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/acpi/arm64/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index e0d2e6e6e40c..655407ad112e 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node) > > pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO); > if (!pdev) > - return PTR_ERR(pdev); > + return -ENOMEM; > > count = ops->iommu_count_resources(node); Thanks for the fix, but Dan beats you to this fix [1] :) [1]: http://www.spinics.net/lists/linux-acpi/msg71383.html Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index e0d2e6e6e40c..655407ad112e 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c @@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node) pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO); if (!pdev) - return PTR_ERR(pdev); + return -ENOMEM; count = ops->iommu_count_resources(node);
If 'platform_device_alloc()' returns NULL, the current code returns 0, which means success. Return -ENOMEM instead. Fixes: 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/acpi/arm64/iort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)