From patchwork Tue Oct 10 08:01:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 9995259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E6FB760230 for ; Tue, 10 Oct 2017 08:02:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D923028112 for ; Tue, 10 Oct 2017 08:02:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CDBCD2811E; Tue, 10 Oct 2017 08:02:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76F6B28112 for ; Tue, 10 Oct 2017 08:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755424AbdJJICR (ORCPT ); Tue, 10 Oct 2017 04:02:17 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36167 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbdJJICQ (ORCPT ); Tue, 10 Oct 2017 04:02:16 -0400 Received: by mail-lf0-f68.google.com with SMTP id g70so1034278lfl.3; Tue, 10 Oct 2017 01:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=+G5Yk4VcKTu6dNgL+1YMphYjr5qerCTGg7bsIhYHkxg=; b=cNaCVSELQLvD5aAhW1rle5UTHjyOVvKSrzdzg7CDlQIhfdUZMUhHHQ71qIsUq157kD r54yL7xJwqaSgHqHFBc5s+FY8TMf9V9aTheXLKWMvEsz+ccFfTpoRQjEGLW5mIAYDONU 7vxLKK9poQ3hCEbZop0/nyTDeDu2IOInNMVxDlI9rFZzM6vlUQy2cl+Ht0Kq/Ust5mc3 TPRwwvQnTdcY0kbYHFQ64xDDZROwzIP+vNg1nlWYcqXjZsExXgFxrHtv01POmvjVpAIW 3YqKCxfKvs78e6G5q8bQ/WVJWzJUukCW6j2OjqfTe0sxnOKnWCZCrpPcSEbZqhiS6uRg Enag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=+G5Yk4VcKTu6dNgL+1YMphYjr5qerCTGg7bsIhYHkxg=; b=U/ZQqzQbsBYy7dLtkvqmrtSMyj3rRA+NQv6bYjr9EUouCBTJ1QQ7RGMA2Oe43TSd8U C5ZLHMXJDszlGCEOZjocY4Iu5ZO/hqtNElv64VolYOcTF1s68h6ARLzmKL42vcXu4Mis jB+dszB2OH4vakbc+mh+7IDtwZ/VkHZ+6RFxWSiEyS5LwXB63sOzxPxZ+xWMUNWHKIdV LSM8hjo2M3U7QKKcI1Nez806D3A2uQ3V1YowEvyl+7c3aYdLGi1skY5ZvojABli2qNGX 0yQaIz+BkjBtqmqeYJ5gjdXV07RHTR8/b1/FS3DelltE06ZdMp+tOpKogEwZV8jzFoUA 1CyQ== X-Gm-Message-State: AMCzsaXwmxi+G86y7vUsm+8wngsEp5DysP9wq7oYYbGm4kx5AcEFpfDS bGJpidgX2XizXS/n7uiBnUM= X-Google-Smtp-Source: AOwi7QBiWxRCBTtUYQszl9d3vEAYIYsBM7ssviX/ENwIlf/9p7Bzn04W1VXnRt3/N7znfphH/fbhHA== X-Received: by 10.46.86.68 with SMTP id k65mr5528631ljb.97.1507622534582; Tue, 10 Oct 2017 01:02:14 -0700 (PDT) Received: from xi.terra (c-fab8e655.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.230.184.250]) by smtp.gmail.com with ESMTPSA id k184sm1672553lfg.53.2017.10.10.01.02.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Oct 2017 01:02:13 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.89) (envelope-from ) id 1e1pUU-0004oC-0q; Tue, 10 Oct 2017 10:02:14 +0200 From: Johan Hovold To: Marcel Holtmann Cc: Gustavo Padovan , Johan Hedberg , linux-bluetooth@vger.kernel.org, Sebastian Reichel , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= , robh@kernel.org, loic.poulain@gmail.com, lukas@wunner.de, hdegoede@redhat.com, linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org, Johan Hovold Subject: [PATCH] Bluetooth: avoid silent hci_bcm ACPI PM regression Date: Tue, 10 Oct 2017 10:01:52 +0200 Message-Id: <20171010080152.18444-1-johan@kernel.org> X-Mailer: git-send-email 2.14.2 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The hci_bcm platform-device hack which was used to implement power management for ACPI devices is being replaced by a serial-device-bus implementation. Unfortunately, when the corresponding change to the ACPI code lands (a change that will stop enumerating and registering the serial-device-node child as a platform device) PM will break silently unless serdev TTY-port controller support has been enabled. Specifically, hciattach (btattach) would still succeed, but power management would no longer work. Although this is strictly a runtime dependency, let's make the driver depend on SERIAL_DEV_CTRL_TTYPORT, which is the particular serdev controller implementation used by the ACPI devices currently managed by this driver, to avoid breaking PM without anyone noticing. Note that the driver already has a (build-time) dependency on the serdev bus code. Signed-off-by: Johan Hovold --- drivers/bluetooth/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index fae5a74dc737..082e1c7329de 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -169,6 +169,7 @@ config BT_HCIUART_BCM bool "Broadcom protocol support" depends on BT_HCIUART depends on BT_HCIUART_SERDEV + depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT) select BT_HCIUART_H4 select BT_BCM help