diff mbox

[v3,4/4] x86/xen: supply rsdp address in boot params for pvh guests

Message ID 20171208151139.30213-5-jgross@suse.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Jürgen Groß Dec. 8, 2017, 3:11 p.m. UTC
When booted via the special PVH entry save the RSDP address set in the
boot information block in struct boot_params. This will enable Xen to
locate the RSDP at an arbitrary address.

Set the boot loader version to 2.14 (0x020e) replacing the wrong 0x0212
which should have been 0x020c.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2: set bootloader version to 2.14 (Roger Pau Monné)
---
 arch/x86/xen/enlighten_pvh.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Jan Beulich Dec. 11, 2017, 10:09 a.m. UTC | #1
>>> On 08.12.17 at 16:11, <jgross@suse.com> wrote:
> Set the boot loader version to 2.14 (0x020e) replacing the wrong 0x0212
> which should have been 0x020c.

This part of the description has become partly stale now with the
new patch 3.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jürgen Groß Dec. 11, 2017, 10:51 a.m. UTC | #2
On 11/12/17 11:09, Jan Beulich wrote:
>>>> On 08.12.17 at 16:11, <jgross@suse.com> wrote:
>> Set the boot loader version to 2.14 (0x020e) replacing the wrong 0x0212
>> which should have been 0x020c.
> 
> This part of the description has become partly stale now with the
> new patch 3.

Indeed. I'll wait for other comments before sending out a new version.

Thanks,


Juergen
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ingo Molnar Dec. 11, 2017, 2:14 p.m. UTC | #3
* Juergen Gross <jgross@suse.com> wrote:

> On 11/12/17 11:09, Jan Beulich wrote:
> >>>> On 08.12.17 at 16:11, <jgross@suse.com> wrote:
> >> Set the boot loader version to 2.14 (0x020e) replacing the wrong 0x0212
> >> which should have been 0x020c.
> > 
> > This part of the description has become partly stale now with the
> > new patch 3.
> 
> Indeed. I'll wait for other comments before sending out a new version.

Looks good to me now, and I've applied the series to tip:x86/boot. I have removed 
this stale sentence from patch #4.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c
index 6e6430cb5e3f..e85e6dafe4bc 100644
--- a/arch/x86/xen/enlighten_pvh.c
+++ b/arch/x86/xen/enlighten_pvh.c
@@ -68,9 +68,12 @@  static void __init init_pvh_bootparams(void)
 	 *
 	 * Version 2.12 supports Xen entry point but we will use default x86/PC
 	 * environment (i.e. hardware_subarch 0).
+	 * The RSDP address is available from version 2.14 on.
 	 */
-	pvh_bootparams.hdr.version = (2 << 8) | 12;
+	pvh_bootparams.hdr.version = (2 << 8) | 14;
 	pvh_bootparams.hdr.type_of_loader = (9 << 4) | 0; /* Xen loader */
+
+	pvh_bootparams.hdr.acpi_rsdp_addr = pvh_start_info.rsdp_paddr;
 }
 
 /*