| Message ID | 20180228105750.6491-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
+ Leif On Wed, Feb 28, 2018 at 2:57 AM, Hans de Goede <hdegoede@redhat.com> wrote: > Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA > reset_resume quirking"), added the Lenovo Yoga 920 to the > btusb_needs_reset_resume_table. > > Testing has shown that this is a false positive and the problems where > caused by issues with the initial fix: commit fd865802c66b ("Bluetooth: > btusb: fix QCA Rome suspend/resume"), which has already been reverted. > > So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at > all and this commit removes it from the btusb_needs_reset_resume_table. > > Note that after this commit the btusb_needs_reset_resume_table is now > empty. It is kept around on purpose, since this whole series of commits > started for a reason and there are actually broken platforms around, > which need to be added to it. This is hilarious. I think we need to go back to the author(s) of commit fd865802c66b and find proper details about said "numerous reported instances" of problems... Anyway: Reviewed-by: Brian Norris <briannorris@chromium.org> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1514836 > Fixes: 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...") > Cc: stable@vger.kernel.org > Cc: Brian Norris <briannorris@chromium.org> > Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> > Tested-by: Kevin Fenzi <kevin@scrye.com> > Suggested-by: Brian Norris <briannorris@chromium.org> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/bluetooth/btusb.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index a4b62f0a93cc..418550eb1522 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] = { > * the module itself. So we use a DMI list to match known broken platforms. > */ > static const struct dmi_system_id btusb_needs_reset_resume_table[] = { > - { > - /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */ > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"), > - }, > - }, > {} > }; > > -- > 2.14.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Brian Norris <briannorris@chromium.org> wrote: > + Leif > > On Wed, Feb 28, 2018 at 2:57 AM, Hans de Goede <hdegoede@redhat.com> wrote: >> Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA >> reset_resume quirking"), added the Lenovo Yoga 920 to the >> btusb_needs_reset_resume_table. >> >> Testing has shown that this is a false positive and the problems where >> caused by issues with the initial fix: commit fd865802c66b ("Bluetooth: >> btusb: fix QCA Rome suspend/resume"), which has already been reverted. >> >> So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at >> all and this commit removes it from the btusb_needs_reset_resume_table. >> >> Note that after this commit the btusb_needs_reset_resume_table is now >> empty. It is kept around on purpose, since this whole series of commits >> started for a reason and there are actually broken platforms around, >> which need to be added to it. > > This is hilarious. > The platform at my hand still needs the quirk though, so the table is quite useful. I’ll send a patch soon. > I think we need to go back to the author(s) of commit fd865802c66b and > find proper details about said "numerous reported instances" of > problems... Anyway: > > Reviewed-by: Brian Norris <briannorris@chromium.org> > >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1514836 >> Fixes: 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...") >> Cc: stable@vger.kernel.org >> Cc: Brian Norris <briannorris@chromium.org> >> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> >> Tested-by: Kevin Fenzi <kevin@scrye.com> >> Suggested-by: Brian Norris <briannorris@chromium.org> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/bluetooth/btusb.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index a4b62f0a93cc..418550eb1522 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] >> = { >> * the module itself. So we use a DMI list to match known broken platforms. >> */ >> static const struct dmi_system_id btusb_needs_reset_resume_table[] = { >> - { >> - /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */ >> - .matches = { >> - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> - DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"), >> - }, >> - }, >> {} >> }; >> >> — >> 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans, > Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA > reset_resume quirking"), added the Lenovo Yoga 920 to the > btusb_needs_reset_resume_table. > > Testing has shown that this is a false positive and the problems where > caused by issues with the initial fix: commit fd865802c66b ("Bluetooth: > btusb: fix QCA Rome suspend/resume"), which has already been reverted. > > So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at > all and this commit removes it from the btusb_needs_reset_resume_table. > > Note that after this commit the btusb_needs_reset_resume_table is now > empty. It is kept around on purpose, since this whole series of commits > started for a reason and there are actually broken platforms around, > which need to be added to it. > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1514836 > Fixes: 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...") > Cc: stable@vger.kernel.org > Cc: Brian Norris <briannorris@chromium.org> > Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> > Tested-by: Kevin Fenzi <kevin@scrye.com> > Suggested-by: Brian Norris <briannorris@chromium.org> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/bluetooth/btusb.c | 7 ------- > 1 file changed, 7 deletions(-) patch has been applied to bluetooth-stable tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index a4b62f0a93cc..418550eb1522 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] = { * the module itself. So we use a DMI list to match known broken platforms. */ static const struct dmi_system_id btusb_needs_reset_resume_table[] = { - { - /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */ - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"), - }, - }, {} };
Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA reset_resume quirking"), added the Lenovo Yoga 920 to the btusb_needs_reset_resume_table. Testing has shown that this is a false positive and the problems where caused by issues with the initial fix: commit fd865802c66b ("Bluetooth: btusb: fix QCA Rome suspend/resume"), which has already been reverted. So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at all and this commit removes it from the btusb_needs_reset_resume_table. Note that after this commit the btusb_needs_reset_resume_table is now empty. It is kept around on purpose, since this whole series of commits started for a reason and there are actually broken platforms around, which need to be added to it. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1514836 Fixes: 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...") Cc: stable@vger.kernel.org Cc: Brian Norris <briannorris@chromium.org> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> Tested-by: Kevin Fenzi <kevin@scrye.com> Suggested-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/bluetooth/btusb.c | 7 ------- 1 file changed, 7 deletions(-)