| Message ID | 20180424074344.23029-1-jslaby@suse.cz (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Tue, Apr 24, 2018 at 12:43 AM, Jiri Slaby <jslaby@suse.cz> wrote: > Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed > setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica > (acpidump) in power/acpi: > ld: unrecognized option '-D_LINUX' > > The tools pass CFLAGS to the linker (incl. -D_LINUX), so revert this > particular change and let LD be $(CC) again. Note that the old behaviour > was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by > the commit 7ed1c1901fe5. We use $(CC) for that reason. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Martin Kelly <martin@martingkelly.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: Robert Moore <robert.moore@intel.com> > Cc: Erik Schmauss <erik.schmauss@intel.com> > Cc: linux-acpi@vger.kernel.org > Cc: devel@acpica.org > --- > tools/power/acpi/Makefile.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config > index 2cccbba64418..f304be71c278 100644 > --- a/tools/power/acpi/Makefile.config > +++ b/tools/power/acpi/Makefile.config > @@ -56,6 +56,7 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} > # to compile vs uClibc, that can be done here as well. > CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- > CROSS_COMPILE ?= $(CROSS) > +LD = $(CC) > HOSTCC = gcc > > # check if compiler option is supported > -- > 2.16.3 > Reviewed-by: Martin Kelly <martin@martingkelly.com> Thanks for noticing this and sorry I missed it! -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, April 24, 2018 9:43:44 AM CEST Jiri Slaby wrote: > Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed > setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica > (acpidump) in power/acpi: > ld: unrecognized option '-D_LINUX' > > The tools pass CFLAGS to the linker (incl. -D_LINUX), so revert this > particular change and let LD be $(CC) again. Note that the old behaviour > was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by > the commit 7ed1c1901fe5. We use $(CC) for that reason. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Martin Kelly <martin@martingkelly.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: Robert Moore <robert.moore@intel.com> > Cc: Erik Schmauss <erik.schmauss@intel.com> > Cc: linux-acpi@vger.kernel.org > Cc: devel@acpica.org > --- > tools/power/acpi/Makefile.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config > index 2cccbba64418..f304be71c278 100644 > --- a/tools/power/acpi/Makefile.config > +++ b/tools/power/acpi/Makefile.config > @@ -56,6 +56,7 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} > # to compile vs uClibc, that can be done here as well. > CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- > CROSS_COMPILE ?= $(CROSS) > +LD = $(CC) > HOSTCC = gcc > > # check if compiler option is supported > Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config index 2cccbba64418..f304be71c278 100644 --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -56,6 +56,7 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} # to compile vs uClibc, that can be done here as well. CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- CROSS_COMPILE ?= $(CROSS) +LD = $(CC) HOSTCC = gcc # check if compiler option is supported
Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica (acpidump) in power/acpi: ld: unrecognized option '-D_LINUX' The tools pass CFLAGS to the linker (incl. -D_LINUX), so revert this particular change and let LD be $(CC) again. Note that the old behaviour was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by the commit 7ed1c1901fe5. We use $(CC) for that reason. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Martin Kelly <martin@martingkelly.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Len Brown <lenb@kernel.org> Cc: Robert Moore <robert.moore@intel.com> Cc: Erik Schmauss <erik.schmauss@intel.com> Cc: linux-acpi@vger.kernel.org Cc: devel@acpica.org --- tools/power/acpi/Makefile.config | 1 + 1 file changed, 1 insertion(+)