From patchwork Tue Apr 24 07:43:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 10358837 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4765B60225 for ; Tue, 24 Apr 2018 07:44:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AE2A28D1F for ; Tue, 24 Apr 2018 07:44:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D8AD28D26; Tue, 24 Apr 2018 07:44:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A71928D1F for ; Tue, 24 Apr 2018 07:44:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755956AbeDXHos (ORCPT ); Tue, 24 Apr 2018 03:44:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:51480 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920AbeDXHor (ORCPT ); Tue, 24 Apr 2018 03:44:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 79C09AEB9; Tue, 24 Apr 2018 07:43:46 +0000 (UTC) From: Jiri Slaby To: rjw@rjwysocki.net Cc: linux-kernel@vger.kernel.org, Jiri Slaby , Martin Kelly , Len Brown , Robert Moore , Erik Schmauss , linux-acpi@vger.kernel.org, devel@acpica.org Subject: [PATCH 1/1] tools: power/acpi, revert to LD = gcc Date: Tue, 24 Apr 2018 09:43:44 +0200 Message-Id: <20180424074344.23029-1-jslaby@suse.cz> X-Mailer: git-send-email 2.16.3 In-Reply-To: <54661ff7-5c2a-473b-e08c-1cd267353c03@martingkelly.com> References: <54661ff7-5c2a-473b-e08c-1cd267353c03@martingkelly.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 7ed1c1901fe5 (tools: fix cross-compile var clobbering) removed setting of LD to $(CROSS_COMPILE)gcc. This broke build of acpica (acpidump) in power/acpi: ld: unrecognized option '-D_LINUX' The tools pass CFLAGS to the linker (incl. -D_LINUX), so revert this particular change and let LD be $(CC) again. Note that the old behaviour was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by the commit 7ed1c1901fe5. We use $(CC) for that reason. Signed-off-by: Jiri Slaby Cc: Martin Kelly Cc: "Rafael J. Wysocki" Cc: Len Brown Cc: Robert Moore Cc: Erik Schmauss Cc: linux-acpi@vger.kernel.org Cc: devel@acpica.org Reviewed-by: Martin Kelly --- tools/power/acpi/Makefile.config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config index 2cccbba64418..f304be71c278 100644 --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -56,6 +56,7 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} # to compile vs uClibc, that can be done here as well. CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- CROSS_COMPILE ?= $(CROSS) +LD = $(CC) HOSTCC = gcc # check if compiler option is supported