| Message ID | 20180808145205.26230-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Bluetooth: Add Kconfig option to enable Realtek protocol for serial devices | expand |
Hi Hans, > Add a new BT_HCIUART_RTL Kconfig option to enable the Realtek protocol for > Bluetooth HCI over serial port interface, mirroring the existing > BT_HCIUART_BCM Kconfig option. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/bluetooth/Kconfig | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig > index 5f953ca8ac5b..1124034d1c7e 100644 > --- a/drivers/bluetooth/Kconfig > +++ b/drivers/bluetooth/Kconfig > @@ -195,6 +195,20 @@ config BT_HCIUART_BCM > > Say Y here to compile support for Broadcom protocol. > > +config BT_HCIUART_RTL > + bool "Realtek protocol support" > + depends on BT_HCIUART > + depends on BT_HCIUART_SERDEV > + depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT) is this one really needed? > + depends on GPIOLIB > + select BT_HCIUART_3WIRE > + select BT_RTL > + help > + The Realtek protocol support enables Bluetooth HCI over serial > + port interface for Realtek Bluetooth controllers. I like the text from my patch better since it mentions 3-Wire serial which is what this one is using. > + > + Say Y here to compile support for the Realtek protocol. > + > config BT_HCIUART_QCA > bool "Qualcomm Atheros protocol support" > depends on BT_HCIUART Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 08/08/2018 05:13 PM, Marcel Holtmann wrote: > Hi Hans, > >> Add a new BT_HCIUART_RTL Kconfig option to enable the Realtek protocol for >> Bluetooth HCI over serial port interface, mirroring the existing >> BT_HCIUART_BCM Kconfig option. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/bluetooth/Kconfig | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig >> index 5f953ca8ac5b..1124034d1c7e 100644 >> --- a/drivers/bluetooth/Kconfig >> +++ b/drivers/bluetooth/Kconfig >> @@ -195,6 +195,20 @@ config BT_HCIUART_BCM >> >> Say Y here to compile support for Broadcom protocol. >> >> +config BT_HCIUART_RTL >> + bool "Realtek protocol support" >> + depends on BT_HCIUART >> + depends on BT_HCIUART_SERDEV >> + depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT) > > is this one really needed? I mirrored this from the equivalent BCM Kconfig option, this bit comes from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4294625e02902 Reading the commit message it seems that this indeed is not necessary for the RTL_BT case. >> + depends on GPIOLIB >> + select BT_HCIUART_3WIRE >> + select BT_RTL >> + help >> + The Realtek protocol support enables Bluetooth HCI over serial >> + port interface for Realtek Bluetooth controllers. > > I like the text from my patch better since it mentions 3-Wire serial which is what this one is using. I've not seen your patch (I'm not subscribed to the list) but if you think your version is better feel free to go with it. Regards, Hans > >> + >> + Say Y here to compile support for the Realtek protocol. >> + >> config BT_HCIUART_QCA >> bool "Qualcomm Atheros protocol support" >> depends on BT_HCIUART > > Regards > > Marcel > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans, >>> Add a new BT_HCIUART_RTL Kconfig option to enable the Realtek protocol for >>> Bluetooth HCI over serial port interface, mirroring the existing >>> BT_HCIUART_BCM Kconfig option. >>> >>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>> --- >>> drivers/bluetooth/Kconfig | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig >>> index 5f953ca8ac5b..1124034d1c7e 100644 >>> --- a/drivers/bluetooth/Kconfig >>> +++ b/drivers/bluetooth/Kconfig >>> @@ -195,6 +195,20 @@ config BT_HCIUART_BCM >>> >>> Say Y here to compile support for Broadcom protocol. >>> >>> +config BT_HCIUART_RTL >>> + bool "Realtek protocol support" >>> + depends on BT_HCIUART >>> + depends on BT_HCIUART_SERDEV >>> + depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT) >> is this one really needed? > > I mirrored this from the equivalent BCM Kconfig option, this bit comes from: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4294625e02902 > > Reading the commit message it seems that this indeed is not necessary for the > RTL_BT case. > >>> + depends on GPIOLIB >>> + select BT_HCIUART_3WIRE >>> + select BT_RTL >>> + help >>> + The Realtek protocol support enables Bluetooth HCI over serial >>> + port interface for Realtek Bluetooth controllers. >> I like the text from my patch better since it mentions 3-Wire serial which is what this one is using. > > I've not seen your patch (I'm not subscribed to the list) but if you think > your version is better feel free to go with it. you can find it in the archives, but I think my patch is the cleaner one. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 5f953ca8ac5b..1124034d1c7e 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -195,6 +195,20 @@ config BT_HCIUART_BCM Say Y here to compile support for Broadcom protocol. +config BT_HCIUART_RTL + bool "Realtek protocol support" + depends on BT_HCIUART + depends on BT_HCIUART_SERDEV + depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT) + depends on GPIOLIB + select BT_HCIUART_3WIRE + select BT_RTL + help + The Realtek protocol support enables Bluetooth HCI over serial + port interface for Realtek Bluetooth controllers. + + Say Y here to compile support for the Realtek protocol. + config BT_HCIUART_QCA bool "Qualcomm Atheros protocol support" depends on BT_HCIUART
Add a new BT_HCIUART_RTL Kconfig option to enable the Realtek protocol for Bluetooth HCI over serial port interface, mirroring the existing BT_HCIUART_BCM Kconfig option. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/bluetooth/Kconfig | 14 ++++++++++++++ 1 file changed, 14 insertions(+)