| Message ID | 20180814095707.5674-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Bluetooth: Make BT_HCIUART_RTL configuration option depend on ACPI | expand |
On Tue, Aug 14, 2018 at 11:57 AM Hans de Goede <hdegoede@redhat.com> wrote: > > At the moment we only support ACPI enumeration for serial port attached > RTL bluetooth controllers. > > This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration > option, fixing the following warning when ACPI is not enabled: > > drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used > > Cc: Arnd Bergmann <arnd@arndb.de> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> This fixes the warning, Acked-by: Arnd Bergmann <arnd@arndb.de> I wonder whether CONFIG_BT_HCIUART_3WIRE should also depend on ACPI and/or become a silent option, since it's currently useless when either ACPI or BT_HCIUART_RTL are disabled, and it seems possible that things break differently when another back-end gets added there. Arnd
Hi Arnd, >> At the moment we only support ACPI enumeration for serial port attached >> RTL bluetooth controllers. >> >> This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration >> option, fixing the following warning when ACPI is not enabled: >> >> drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used >> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Reported-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > This fixes the warning, > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > I wonder whether CONFIG_BT_HCIUART_3WIRE should also > depend on ACPI and/or become a silent option, since it's currently > useless when either ACPI or BT_HCIUART_RTL are disabled, > and it seems possible that things break differently when another > back-end gets added there. why would it be useless? There is still a line discipline mode that it can be used for. Moving this all to the new bt3wire.c driver would have been cleaner and less Kconfig messy. Regards Marcel
On Tue, Aug 14, 2018 at 12:36 PM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Arnd, > > >> At the moment we only support ACPI enumeration for serial port attached > >> RTL bluetooth controllers. > >> > >> This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration > >> option, fixing the following warning when ACPI is not enabled: > >> > >> drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used > >> > >> Cc: Arnd Bergmann <arnd@arndb.de> > >> Reported-by: Arnd Bergmann <arnd@arndb.de> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > > This fixes the warning, > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > I wonder whether CONFIG_BT_HCIUART_3WIRE should also > > depend on ACPI and/or become a silent option, since it's currently > > useless when either ACPI or BT_HCIUART_RTL are disabled, > > and it seems possible that things break differently when another > > back-end gets added there. > > why would it be useless? There is still a line discipline mode that it can be used for. Ah, I see. It's all fine then. Arnd
On Tue, Aug 14, 2018 at 12:01 PM Hans de Goede <hdegoede@redhat.com> wrote: > At the moment we only support ACPI enumeration for serial port attached > RTL bluetooth controllers. > > This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration > option, fixing the following warning when ACPI is not enabled: > > drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used > > Cc: Arnd Bergmann <arnd@arndb.de> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
Hi Hans, > At the moment we only support ACPI enumeration for serial port attached > RTL bluetooth controllers. > > This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration > option, fixing the following warning when ACPI is not enabled: > > drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used > > Cc: Arnd Bergmann <arnd@arndb.de> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/bluetooth/Kconfig | 1 + > 1 file changed, 1 insertion(+) patch has been applied bluetooth-stable tree. Regards Marcel
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 933eb90d1ce2..709ed3f7dfe8 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -200,6 +200,7 @@ config BT_HCIUART_RTL depends on BT_HCIUART depends on BT_HCIUART_SERDEV depends on GPIOLIB + depends on ACPI select BT_HCIUART_3WIRE select BT_RTL help
At the moment we only support ACPI enumeration for serial port attached RTL bluetooth controllers. This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration option, fixing the following warning when ACPI is not enabled: drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used Cc: Arnd Bergmann <arnd@arndb.de> Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/bluetooth/Kconfig | 1 + 1 file changed, 1 insertion(+)