| Message ID | 20190105100606.6673-10-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Specify CONFIG_PCI dependency explicitly | expand |
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends > on PCI. For this reason, add a direct dependency to CONFIG_PCI here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..1b9401fe94c0 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC > > config MMC_SDHCI_ACPI > tristate "SDHCI support for ACPI enumerated SDHCI controllers" > - depends on MMC_SDHCI && ACPI > + depends on MMC_SDHCI && ACPI && PCI > select IOSF_MBI if X86 > help > This selects support for ACPI enumerated SDHCI controllers, > -- Any objections against this one from anyone?
On 7/01/19 1:17 PM, Rafael J. Wysocki wrote: > On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote: >> >> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without >> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were >> satisfied implicitly through dependencies on CONFIG_ACPI have to be >> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends >> on PCI. For this reason, add a direct dependency to CONFIG_PCI here. >> >> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") >> Signed-off-by: Sinan Kaya <okaya@kernel.org> >> --- >> drivers/mmc/host/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index e26b8145efb3..1b9401fe94c0 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC >> >> config MMC_SDHCI_ACPI >> tristate "SDHCI support for ACPI enumerated SDHCI controllers" >> - depends on MMC_SDHCI && ACPI >> + depends on MMC_SDHCI && ACPI && PCI >> select IOSF_MBI if X86 >> help >> This selects support for ACPI enumerated SDHCI controllers, >> -- > > Any objections against this one from anyone? + QCOM and AMD contributors
Hi On 1/7/2019 6:12 PM, Adrian Hunter wrote: > On 7/01/19 1:17 PM, Rafael J. Wysocki wrote: >> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote: >>> >>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without >>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were >>> satisfied implicitly through dependencies on CONFIG_ACPI have to be >>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends >>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here. >>> >>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") >>> Signed-off-by: Sinan Kaya <okaya@kernel.org> >>> --- >>> drivers/mmc/host/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>> index e26b8145efb3..1b9401fe94c0 100644 >>> --- a/drivers/mmc/host/Kconfig >>> +++ b/drivers/mmc/host/Kconfig >>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC >>> >>> config MMC_SDHCI_ACPI >>> tristate "SDHCI support for ACPI enumerated SDHCI controllers" >>> - depends on MMC_SDHCI && ACPI >>> + depends on MMC_SDHCI && ACPI && PCI >>> select IOSF_MBI if X86 >>> help >>> This selects support for ACPI enumerated SDHCI controllers, >>> -- >> >> Any objections against this one from anyone? > > + QCOM and AMD contributors > No issues with us as we have separate PCI based driver and ACPI based driver. Regards Nehal Shah
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends > on PCI. For this reason, add a direct dependency to CONFIG_PCI here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> Acked-by: Arnd Bergmann <arnd@arndb.de>
On 2019/1/7 20:43, Adrian Hunter wrote: > On 7/01/19 1:17 PM, Rafael J. Wysocki wrote: >> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote: >>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without >>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were >>> satisfied implicitly through dependencies on CONFIG_ACPI have to be >>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends >>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here. >>> >>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") >>> Signed-off-by: Sinan Kaya <okaya@kernel.org> >>> --- >>> drivers/mmc/host/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>> index e26b8145efb3..1b9401fe94c0 100644 >>> --- a/drivers/mmc/host/Kconfig >>> +++ b/drivers/mmc/host/Kconfig >>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC >>> >>> config MMC_SDHCI_ACPI >>> tristate "SDHCI support for ACPI enumerated SDHCI controllers" >>> - depends on MMC_SDHCI && ACPI >>> + depends on MMC_SDHCI && ACPI && PCI >>> select IOSF_MBI if X86 >>> help >>> This selects support for ACPI enumerated SDHCI controllers, >>> -- >> Any objections against this one from anyone? > + QCOM and AMD contributors > No issue with QCOM. Cheers Dongsheng
On 5/01/19 12:06 PM, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends > on PCI. For this reason, add a direct dependency to CONFIG_PCI here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..1b9401fe94c0 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC > > config MMC_SDHCI_ACPI > tristate "SDHCI support for ACPI enumerated SDHCI controllers" > - depends on MMC_SDHCI && ACPI > + depends on MMC_SDHCI && ACPI && PCI > select IOSF_MBI if X86 > help > This selects support for ACPI enumerated SDHCI controllers, >
On Sat, 5 Jan 2019 at 11:06, Sinan Kaya <okaya@kernel.org> wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends > on PCI. For this reason, add a direct dependency to CONFIG_PCI here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..1b9401fe94c0 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC > > config MMC_SDHCI_ACPI > tristate "SDHCI support for ACPI enumerated SDHCI controllers" > - depends on MMC_SDHCI && ACPI > + depends on MMC_SDHCI && ACPI && PCI > select IOSF_MBI if X86 > help > This selects support for ACPI enumerated SDHCI controllers, > -- > 2.19.0 >
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index e26b8145efb3..1b9401fe94c0 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -116,7 +116,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers,
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends on PCI. For this reason, add a direct dependency to CONFIG_PCI here. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)