| Message ID | 20190124175702.4801-2-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [for,next,v2,1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC | expand |
On Thu, Jan 24, 2019 at 7:57 PM Sinan Kaya <okaya@kernel.org> wrote: > > Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the > warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE. > > SAMSUNG_Q10 selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE > depends on BACKLIGHT_LCD_SUPPORT. > > Copy BACKLIGHT_LCD_SUPPORT dependency into SAMSUNG_Q10 to fix: > > WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE > Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] > Selected by [y]: > - SAMSUNG_Q10 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] Thanks for the fix. One comment below though. > config SAMSUNG_Q10 > tristate "Samsung Q10 Extras" > - depends on ACPI > + depends on ACPI && BACKLIGHT_LCD_SUPPORT I would like rather see it on a separate line in both patches. Rafael, you may take it if it feels comfortable. > select BACKLIGHT_CLASS_DEVICE > ---help--- > This driver provides support for backlight control on Samsung Q10 > -- > 2.19.0 >
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index b84c2c5b6684..129e37c296a7 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1127,7 +1127,7 @@ config INTEL_OAKTRAIL config SAMSUNG_Q10 tristate "Samsung Q10 Extras" - depends on ACPI + depends on ACPI && BACKLIGHT_LCD_SUPPORT select BACKLIGHT_CLASS_DEVICE ---help--- This driver provides support for backlight control on Samsung Q10
Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE. SAMSUNG_Q10 selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT. Copy BACKLIGHT_LCD_SUPPORT dependency into SAMSUNG_Q10 to fix: WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] Selected by [y]: - SAMSUNG_Q10 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)