@@ -155,7 +155,7 @@ static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data)
*/
int i2c_acpi_get_irq(struct device *dev)
{
- struct acpi_device *adev = container_of(dev, struct acpi_device, dev);
+ struct acpi_device *adev = ACPI_COMPANION(dev);
struct list_head resource_list;
int irq = -ENOENT;
int ret;
@@ -207,11 +207,6 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
if (adapter_handle)
*adapter_handle = lookup.adapter_handle;
- /* Then fill IRQ number if any */
- info->irq = i2c_acpi_get_irq(&adev->dev);
- if (info->irq < 0)
- return info->irq;
-
acpi_set_modalias(adev, dev_name(&adev->dev), info->type,
sizeof(info->type));
@@ -327,7 +327,10 @@ static int i2c_device_probe(struct device *dev)
if (irq == -EINVAL || irq == -ENODATA)
irq = of_irq_get(dev->of_node, 0);
} else if (ACPI_COMPANION(dev)) {
- irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
+ irq = i2c_acpi_get_irq(dev);
+
+ if (irq == -ENOENT)
+ irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
}
if (irq == -EPROBE_DEFER)
return irq;
Bring the ACPI path in sync with the device tree path and handle all the IRQ fetching at probe time. This leaves the only IRQ handling at device registration time being that which is passed directly through the board info as either a resource or an actual IRQ number. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- Changes since v5: - Pass a struct device rather than acpi_device to i2c_acpi_get_irq. Thanks, Charles drivers/i2c/i2c-core-acpi.c | 7 +------ drivers/i2c/i2c-core-base.c | 5 ++++- 2 files changed, 5 insertions(+), 7 deletions(-)