diff mbox series

[-next] ACPI: SBS: remove unused variable 'SMBUS_PEC'

Message ID 20190822144346.12028-1-yuehaibing@huawei.com (mailing list archive)
State Mainlined, archived
Headers show
Series [-next] ACPI: SBS: remove unused variable 'SMBUS_PEC' | expand

Commit Message

Yue Haibing Aug. 22, 2019, 2:43 p.m. UTC
drivers/acpi/sbshc.h:18:17: warning:
 SMBUS_PEC defined but not used [-Wunused-const-variable=]

SMBUS_PEC is never used since introduction in
commit 91087dfa51a2 ("ACPI: SBS: Split host
controller (ACPI0001) from SBS driver (ACPI0002)"),
so just remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/acpi/sbshc.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Rafael J. Wysocki Aug. 26, 2019, 9:08 a.m. UTC | #1
On Thursday, August 22, 2019 4:43:46 PM CEST YueHaibing wrote:
> drivers/acpi/sbshc.h:18:17: warning:
>  SMBUS_PEC defined but not used [-Wunused-const-variable=]
> 
> SMBUS_PEC is never used since introduction in
> commit 91087dfa51a2 ("ACPI: SBS: Split host
> controller (ACPI0001) from SBS driver (ACPI0002)"),
> so just remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/acpi/sbshc.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 06372a3..c3522bb 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -15,8 +15,6 @@ enum acpi_smb_protocol {
>  	SMBUS_BLOCK_PROCESS_CALL = 0xd,
>  };
>  
> -static const u8 SMBUS_PEC = 0x80;
> -
>  enum acpi_sbs_device_addr {
>  	ACPI_SBS_CHARGER = 0x9,
>  	ACPI_SBS_MANAGER = 0xa,
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
index 06372a3..c3522bb 100644
--- a/drivers/acpi/sbshc.h
+++ b/drivers/acpi/sbshc.h
@@ -15,8 +15,6 @@  enum acpi_smb_protocol {
 	SMBUS_BLOCK_PROCESS_CALL = 0xd,
 };
 
-static const u8 SMBUS_PEC = 0x80;
-
 enum acpi_sbs_device_addr {
 	ACPI_SBS_CHARGER = 0x9,
 	ACPI_SBS_MANAGER = 0xa,