diff mbox series

[22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()

Message ID 20200223231711.157699-23-jbi.octave@gmail.com (mailing list archive)
State Mainlined, archived
Headers show
Series None | expand

Commit Message

Jules Irenge Feb. 23, 2020, 11:17 p.m. UTC
Sparse reports a warning at acpi_os_acquire_lock()

warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock

The root cause is the missing annotation at acpi_os_acquire_lock()
Add the missing annotation __acquires(lockp)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/acpi/osl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafael J. Wysocki March 4, 2020, 11 a.m. UTC | #1
On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
> 
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
> 
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/acpi/osl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
>   */
>  
>  acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> +	__acquires(lockp)
>  {
>  	acpi_cpu_flags flags;
>  	spin_lock_irqsave(lockp, flags);
> 

Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.

Thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 41168c027a5a..7094abc5ffc6 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1598,6 +1598,7 @@  void acpi_os_delete_lock(acpi_spinlock handle)
  */
 
 acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
+	__acquires(lockp)
 {
 	acpi_cpu_flags flags;
 	spin_lock_irqsave(lockp, flags);