| Message ID | 20200728082857.10829-2-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/4] ACPI: APD: Change name from ST to FCH | expand |
On 7/29/2020 6:56 AM, Stephen Boyd wrote: > Quoting Akshu Agrawal (2020-07-28 01:28:53) >> AMD SoC general pupose clk is present in new platforms with >> same MMIO mappings. We can reuse the same clk handler support >> for other platforms. Hence, changing name from ST(SoC) to FCH(IP) >> >> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >> --- > Acked-by: Stephen Boyd <sboyd@kernel.org> Hi Rafael, I see the status of these patches as Not Applicable in patchwork, is there any pending action for me? Thanks, Akshu
On Fri, Jul 31, 2020 at 2:44 AM Agrawal, Akshu <aagrawal2@amd.com> wrote: > > > On 7/29/2020 6:56 AM, Stephen Boyd wrote: > > Quoting Akshu Agrawal (2020-07-28 01:28:53) > >> AMD SoC general pupose clk is present in new platforms with > >> same MMIO mappings. We can reuse the same clk handler support > >> for other platforms. Hence, changing name from ST(SoC) to FCH(IP) > >> > >> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> > >> --- > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Hi Rafael, > I see the status of these patches as Not Applicable in patchwork, is > there any pending action for me? Yes, there is. You need to let me know if you want me to apply them (and I mean the whole series). :-) Besides, I only can see 3 out of 4 patches, so if you want me to apply them, can you please resend the whole series with CCs to linux-acpi? Thanks!
On 7/31/2020 4:44 PM, Rafael J. Wysocki wrote: > On Fri, Jul 31, 2020 at 2:44 AM Agrawal, Akshu <aagrawal2@amd.com> wrote: >> >> On 7/29/2020 6:56 AM, Stephen Boyd wrote: >>> Quoting Akshu Agrawal (2020-07-28 01:28:53) >>>> AMD SoC general pupose clk is present in new platforms with >>>> same MMIO mappings. We can reuse the same clk handler support >>>> for other platforms. Hence, changing name from ST(SoC) to FCH(IP) >>>> >>>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >>>> --- >>> Acked-by: Stephen Boyd <sboyd@kernel.org> >> Hi Rafael, >> I see the status of these patches as Not Applicable in patchwork, is >> there any pending action for me? > Yes, there is. > > You need to let me know if you want me to apply them (and I mean the > whole series). :-) Yes, please apply the whole series. > > Besides, I only can see 3 out of 4 patches, so if you want me to apply > them, can you please resend the whole series with CCs to linux-acpi? Sending them again with cc to linux-acpi. Thanks, Akshu
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index ba2612e9a0eb..2d99e46add1a 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -8,7 +8,7 @@ */ #include <linux/clk-provider.h> -#include <linux/platform_data/clk-st.h> +#include <linux/platform_data/clk-fch.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/clkdev.h> @@ -79,11 +79,11 @@ static int misc_check_res(struct acpi_resource *ares, void *data) return !acpi_dev_resource_memory(ares, &res); } -static int st_misc_setup(struct apd_private_data *pdata) +static int fch_misc_setup(struct apd_private_data *pdata) { struct acpi_device *adev = pdata->adev; struct platform_device *clkdev; - struct st_clk_data *clk_data; + struct fch_clk_data *clk_data; struct resource_entry *rentry; struct list_head resource_list; int ret; @@ -106,7 +106,7 @@ static int st_misc_setup(struct apd_private_data *pdata) acpi_dev_free_resource_list(&resource_list); - clkdev = platform_device_register_data(&adev->dev, "clk-st", + clkdev = platform_device_register_data(&adev->dev, "clk-fch", PLATFORM_DEVID_NONE, clk_data, sizeof(*clk_data)); return PTR_ERR_OR_ZERO(clkdev); @@ -135,8 +135,8 @@ static const struct apd_device_desc cz_uart_desc = { .properties = uart_properties, }; -static const struct apd_device_desc st_misc_desc = { - .setup = st_misc_setup, +static const struct apd_device_desc fch_misc_desc = { + .setup = fch_misc_setup, }; #endif @@ -239,7 +239,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = { { "AMD0020", APD_ADDR(cz_uart_desc) }, { "AMDI0020", APD_ADDR(cz_uart_desc) }, { "AMD0030", }, - { "AMD0040", APD_ADDR(st_misc_desc)}, + { "AMD0040", APD_ADDR(fch_misc_desc)}, #endif #ifdef CONFIG_ARM64 { "APMC0D0F", APD_ADDR(xgene_i2c_desc) }, diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index 25d4b97aff9b..c2438874d9f2 100644 --- a/drivers/clk/x86/clk-st.c +++ b/drivers/clk/x86/clk-st.c @@ -8,7 +8,7 @@ #include <linux/clk.h> #include <linux/clkdev.h> #include <linux/clk-provider.h> -#include <linux/platform_data/clk-st.h> +#include <linux/platform_data/clk-fch.h> #include <linux/platform_device.h> /* Clock Driving Strength 2 register */ @@ -31,7 +31,7 @@ static struct clk_hw *hws[ST_MAX_CLKS]; static int st_clk_probe(struct platform_device *pdev) { - struct st_clk_data *st_data; + struct fch_clk_data *st_data; st_data = dev_get_platdata(&pdev->dev); if (!st_data || !st_data->base) diff --git a/include/linux/platform_data/clk-st.h b/include/linux/platform_data/clk-fch.h similarity index 53% rename from include/linux/platform_data/clk-st.h rename to include/linux/platform_data/clk-fch.h index 7cdb6a402b35..850ca776156d 100644 --- a/include/linux/platform_data/clk-st.h +++ b/include/linux/platform_data/clk-fch.h @@ -1,17 +1,17 @@ /* SPDX-License-Identifier: MIT */ /* - * clock framework for AMD Stoney based clock + * clock framework for AMD misc clocks * * Copyright 2018 Advanced Micro Devices, Inc. */ -#ifndef __CLK_ST_H -#define __CLK_ST_H +#ifndef __CLK_FCH_H +#define __CLK_FCH_H #include <linux/compiler.h> -struct st_clk_data { +struct fch_clk_data { void __iomem *base; }; -#endif /* __CLK_ST_H */ +#endif /* __CLK_FCH_H */
AMD SoC general pupose clk is present in new platforms with same MMIO mappings. We can reuse the same clk handler support for other platforms. Hence, changing name from ST(SoC) to FCH(IP) Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- v2: pulled in clk changes so that patch compiles individually drivers/acpi/acpi_apd.c | 14 +++++++------- drivers/clk/x86/clk-st.c | 4 ++-- .../linux/platform_data/{clk-st.h => clk-fch.h} | 10 +++++----- 3 files changed, 14 insertions(+), 14 deletions(-) rename include/linux/platform_data/{clk-st.h => clk-fch.h} (53%)