| Message ID | 20201029193243.61546-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [v2,1/3] Documentation: firmware-guide: gpio-properties: Fix factual mistakes | expand |
On Thu, Oct 29, 2020 at 8:32 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > It appears that people may misinterpret active_low field in _DSD > for GpioInt() resource. Add a paragraph to clarify this. > > Reported-by: Ricardo Ribalda <ribalda@chromium.org> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > --- > v2: added Rb tag (Mika) > Documentation/firmware-guide/acpi/gpio-properties.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst > index e6e65ceb2ca1..370fe46c6af9 100644 > --- a/Documentation/firmware-guide/acpi/gpio-properties.rst > +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst > @@ -55,6 +55,9 @@ Since ACPI GpioIo() resource does not have a field saying whether it is > active low or high, the "active_low" argument can be used here. Setting > it to 1 marks the GPIO as active low. > > +Note, active_low in _DSD does not make sense for GpioInt() resource and > +must be 0. GpioInt() resource has its own means of defining it. > + > In our Bluetooth example the "reset-gpios" refers to the second GpioIo() > resource, second pin in that resource with the GPIO number of 31. > > -- > 2.28.0 >
diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst index e6e65ceb2ca1..370fe46c6af9 100644 --- a/Documentation/firmware-guide/acpi/gpio-properties.rst +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst @@ -55,6 +55,9 @@ Since ACPI GpioIo() resource does not have a field saying whether it is active low or high, the "active_low" argument can be used here. Setting it to 1 marks the GPIO as active low. +Note, active_low in _DSD does not make sense for GpioInt() resource and +must be 0. GpioInt() resource has its own means of defining it. + In our Bluetooth example the "reset-gpios" refers to the second GpioIo() resource, second pin in that resource with the GPIO number of 31.