| Message ID | 20210422192442.706906-2-sathyanarayanan.kuppuswamy@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add multiprocessor wake-up support | expand |
On 4/22/21 12:24 PM, Kuppuswamy Sathyanarayanan wrote: > ACPICA commit f1ee04207a212f6c519441e7e25397649ebc4cea > > Add Multiprocessor Wakeup Mailbox Structure definition. It is useful > in parsing MADT Wake table. > > Link: https://github.com/acpica/acpica/commit/f1ee0420 > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > Signed-off-by: Bob Moore <robert.moore@intel.com> > Signed-off-by: Erik Kaneda <erik.kaneda@intel.com> This SoB chain doesn't look right. This is what it would have been if You sent it to Bob who sent it to Erik, who submitted it.
On 4/22/21 12:37 PM, Dave Hansen wrote: > On 4/22/21 12:24 PM, Kuppuswamy Sathyanarayanan wrote: >> ACPICA commit f1ee04207a212f6c519441e7e25397649ebc4cea >> >> Add Multiprocessor Wakeup Mailbox Structure definition. It is useful >> in parsing MADT Wake table. >> >> Link: https://github.com/acpica/acpica/commit/f1ee0420 >> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> Signed-off-by: Bob Moore <robert.moore@intel.com> >> Signed-off-by: Erik Kaneda <erik.kaneda@intel.com> > > This SoB chain doesn't look right. This is what it would have been if > You sent it to Bob who sent it to Erik, who submitted it. Internally, its submitted to Bob and Erik for ACPICA merge. I think Sign-off is added to track it. >
On Thu, Apr 22, 2021 at 12:46:13PM -0700, Kuppuswamy, Sathyanarayanan wrote: > > This SoB chain doesn't look right. This is what it would have been if > > You sent it to Bob who sent it to Erik, who submitted it. > Internally, its submitted to Bob and Erik for ACPICA merge. > I think Sign-off is added to track it. This is not how this works - when Erik/Bob merge it, *then* they add their SOB. Right now it should have only your SOB. Documentation/process/submitting-patches.rst, section "Sign your work - the Developer's Certificate of Origin" Thx.
> -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Thursday, April 22, 2021 12:56 PM > To: Kuppuswamy, Sathyanarayanan > <sathyanarayanan.kuppuswamy@linux.intel.com> > Cc: Hansen, Dave <dave.hansen@intel.com>; Rafael J Wysocki > <rjw@rjwysocki.net>; Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar > <mingo@redhat.com>; H . Peter Anvin <hpa@zytor.com>; Peter Zijlstra > <peterz@infradead.org>; Len Brown <lenb@kernel.org>; Moore, Robert > <robert.moore@intel.com>; Kaneda, Erik <erik.kaneda@intel.com>; linux- > acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org; > x86@kernel.org > Subject: Re: [PATCH 1/3] ACPICA: ACPI 6.4: MADT: add Multiprocessor > Wakeup Mailbox Structure > > On Thu, Apr 22, 2021 at 12:46:13PM -0700, Kuppuswamy, Sathyanarayanan > wrote: > > > This SoB chain doesn't look right. This is what it would have been if > > > You sent it to Bob who sent it to Erik, who submitted it. > > Internally, its submitted to Bob and Erik for ACPICA merge. > > I think Sign-off is added to track it. > > This is not how this works - when Erik/Bob merge it, *then* they add > their SOB. Right now it should have only your SOB. Sorry about that. The script to format the ACPICA upstream to Linux ACPICA automatically adds signed off-by tags from me and Bob to the patch. This would work if we go through the normal process of running the Linux script after we do an ACPICA release. We decided to submit this earlier to meet Sathya's deadline. Sathya, Please drop these lines from this patch and the SVKL patch. Erik > > Documentation/process/submitting-patches.rst, section "Sign your work - > the Developer's Certificate of Origin" > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
On 4/22/21 1:51 PM, Kaneda, Erik wrote: >> This is not how this works - when Erik/Bob merge it,*then* they add >> their SOB. Right now it should have only your SOB. > Sorry about that. The script to format the ACPICA upstream to Linux ACPICA automatically adds signed off-by tags from me and Bob to the patch. This would work if we go through the normal process of running the Linux script after we do an ACPICA release. We decided to submit this earlier to meet Sathya's deadline. > > Sathya, Please drop these lines from this patch and the SVKL patch. Will remove it.
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index b2362600b9ff..7dce422f6119 100644 --- a/include/acpi/actbl2.h +++ b/include/acpi/actbl2.h @@ -733,6 +733,20 @@ struct acpi_madt_multiproc_wakeup { u64 base_address; }; +#define ACPI_MULTIPROC_WAKEUP_MB_OS_SIZE 2032 +#define ACPI_MULTIPROC_WAKEUP_MB_FIRMWARE_SIZE 2048 + +struct acpi_madt_multiproc_wakeup_mailbox { + u16 command; + u16 reserved; /* reserved - must be zero */ + u32 apic_id; + u64 wakeup_vector; + u8 reserved_os[ACPI_MULTIPROC_WAKEUP_MB_OS_SIZE]; /* reserved for OS use */ + u8 reserved_firmware[ACPI_MULTIPROC_WAKEUP_MB_FIRMWARE_SIZE]; /* reserved for firmware use */ +}; + +#define ACPI_MP_WAKE_COMMAND_WAKEUP 1 + /* * Common flags fields for MADT subtables */