| Message ID | 20210428110536.edy74gsobkgtd6al@ubuntu (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | MAINTAINERS: mark isapnp as obsolete | expand |
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > isapnp code is very old and according to this link > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > This change is in follow up to > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> Has the maintainer said this is unsupported? That's who you should take suggestions from :) thanks, greg k-h
On 21/04/28 01:11PM, Greg KH wrote: > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > isapnp code is very old and according to this link > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > > This change is in follow up to > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > Has the maintainer said this is unsupported? > > That's who you should take suggestions from :) > > thanks, > > greg k-h Leon said he thinks it is unsupported (I've also cc'd him). So, I've sent this patch to get the feedback from the maintainer. Thanks, Anupama
On Wed, Apr 28, 2021 at 05:10:57PM +0530, Anupama K Patil wrote: > On 21/04/28 01:11PM, Greg KH wrote: > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > > isapnp code is very old and according to this link > > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > > > > This change is in follow up to > > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > > > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > > Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > Has the maintainer said this is unsupported? > > > > That's who you should take suggestions from :) > > > > thanks, > > > > greg k-h > > Leon said he thinks it is unsupported (I've also cc'd him). So, I've sent this patch > to get the feedback from the maintainer. Leon said something different. https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#m6c837180c8d6496d5bcbb8526e274c4239844be0 ------ > If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file? I think so, but think that "Odd Fixes" better describes that Rafael wrote. ------ > > Thanks, > Anupama
On 21/04/28 02:48PM, Leon Romanovsky wrote: > On Wed, Apr 28, 2021 at 05:10:57PM +0530, Anupama K Patil wrote: > > On 21/04/28 01:11PM, Greg KH wrote: > > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > > > isapnp code is very old and according to this link > > > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > > > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > > > > > > This change is in follow up to > > > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > > > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > > > > > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > > > Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > > > Has the maintainer said this is unsupported? > > > > > > That's who you should take suggestions from :) > > > > > > thanks, > > > > > > greg k-h > > > > Leon said he thinks it is unsupported (I've also cc'd him). So, I've sent this patch > > to get the feedback from the maintainer. > > Leon said something different. > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#m6c837180c8d6496d5bcbb8526e274c4239844be0 > ------ > > If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file? > > I think so, but think that "Odd Fixes" better describes that Rafael wrote. > ------ Sorry about that! but does checkpatch tell people not to send patches if it's 'Odd fixes'? Should I wait for the maintainer's reply before doing anything else? > > > > > Thanks, > > Anupama
Dne 28. 04. 21 v 13:11 Greg KH napsal(a): > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: >> isapnp code is very old and according to this link >> https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications >> from Wikipedia, even Windows Vista disabled ISA PnP by default. >> >> This change is in follow up to >> https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u >> and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u >> >> Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> >> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > Has the maintainer said this is unsupported? I've no idea, if there're any users at the time, but there are many drivers which depend on this code. I'll try to reply to patch threads. Jaroslav
On Wed, Apr 28, 2021 at 05:43:29PM +0530, Anupama K Patil wrote: > On 21/04/28 02:48PM, Leon Romanovsky wrote: > > On Wed, Apr 28, 2021 at 05:10:57PM +0530, Anupama K Patil wrote: > > > On 21/04/28 01:11PM, Greg KH wrote: > > > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > > > > isapnp code is very old and according to this link > > > > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > > > > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > > > > > > > > This change is in follow up to > > > > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > > > > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > > > > > > > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > > > > Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > > > > > Has the maintainer said this is unsupported? > > > > > > > > That's who you should take suggestions from :) > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Leon said he thinks it is unsupported (I've also cc'd him). So, I've sent this patch > > > to get the feedback from the maintainer. > > > > Leon said something different. > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#m6c837180c8d6496d5bcbb8526e274c4239844be0 > > ------ > > > If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file? > > > > I think so, but think that "Odd Fixes" better describes that Rafael wrote. > > ------ > Sorry about that! but does checkpatch tell people not to send patches if it's 'Odd fixes'? I don't think so, but people should check MAINTIANERS file before they send patches and it has an explanation what "Odd fixes" means. > Should I wait for the maintainer's reply before doing anything else? Yes, please > > > > > > > > Thanks, > > > Anupama
On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote: > Dne 28. 04. 21 v 13:11 Greg KH napsal(a): > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > >> isapnp code is very old and according to this link > >> https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > >> from Wikipedia, even Windows Vista disabled ISA PnP by default. > >> > >> This change is in follow up to > >> https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > >> and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > >> > >> Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > >> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > Has the maintainer said this is unsupported? > > I've no idea, if there're any users at the time, but there are many drivers > which depend on this code. IMHO, this is exactly "Odd fixes" - code not really dead, but not really alive too. Thanks > > I'll try to reply to patch threads. > > Jaroslav > > -- > Jaroslav Kysela <perex@perex.cz> > Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
On 21/04/28 03:23PM, Leon Romanovsky wrote: > On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote: > > Dne 28. 04. 21 v 13:11 Greg KH napsal(a): > > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > >> isapnp code is very old and according to this link > > >> https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > >> from Wikipedia, even Windows Vista disabled ISA PnP by default. > > >> > > >> This change is in follow up to > > >> https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > >> and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > >> > > >> Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > >> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > > > Has the maintainer said this is unsupported? > > > > I've no idea, if there're any users at the time, but there are many drivers > > which depend on this code. > > IMHO, this is exactly "Odd fixes" - code not really dead, but not really > alive too. Okay! Does this have to come around as a v2 with 'Odd Fixes' instead of obsolete? Or should that be a separate patch? Or should we just wait for the maintainer's reply? Sorry i'm a little confused. thanks, karthik > > Thanks > > > > > I'll try to reply to patch threads. > > > > Jaroslav > > > > -- > > Jaroslav Kysela <perex@perex.cz> > > Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
On Wed, Apr 28, 2021 at 2:32 PM B K Karthik <bkkarthik@pesu.pes.edu> wrote: > > On 21/04/28 03:23PM, Leon Romanovsky wrote: > > On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote: > > > Dne 28. 04. 21 v 13:11 Greg KH napsal(a): > > > > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > > >> isapnp code is very old and according to this link > > > >> https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > > >> from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > >> > > > >> This change is in follow up to > > > >> https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > > >> and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > >> > > > >> Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > > >> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> > > > > > > > > Has the maintainer said this is unsupported? > > > > > > I've no idea, if there're any users at the time, but there are many drivers > > > which depend on this code. > > > > IMHO, this is exactly "Odd fixes" - code not really dead, but not really > > alive too. > > Okay! Does this have to come around as a v2 with 'Odd Fixes' instead of obsolete? > Or should that be a separate patch? > > Or should we just wait for the maintainer's reply? > Sorry i'm a little confused. I don't think that the MAINTAINERS entry needs to be updated. Technically, this code is maintained, but because the availability of systems on which to test changes is kind of limited, intrusive functional changes in it should better be avoided. Thanks!
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > isapnp code is very old and according to this link > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > This change is in follow up to > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> This person should not have suggested this, sorry if you were lead astray. The maintainer is in charge of this type of thing, it's a bit rude to try to "force" someone's hand by doing this. Be careful. thanks, greg k-h
On 21/04/29 05:25PM, Greg KH wrote: > On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote: > > isapnp code is very old and according to this link > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > from Wikipedia, even Windows Vista disabled ISA PnP by default. > > > > This change is in follow up to > > https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u > > and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u > > > > Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> > > This person should not have suggested this, sorry if you were lead > astray. The maintainer is in charge of this type of thing, it's a bit > rude to try to "force" someone's hand by doing this. Be careful. Yes I shouldn't have suggested this change. Sorry for that! I won't make such a mistake again. Sorry for wasting your valuable time to everyone cc'ed in this thread. Karthik
diff --git a/MAINTAINERS b/MAINTAINERS index 04e7de8c95be..215e05d93c60 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9534,7 +9534,7 @@ F: drivers/media/radio/radio-isa* ISAPNP M: Jaroslav Kysela <perex@perex.cz> -S: Maintained +S: Obsolete F: Documentation/driver-api/isapnp.rst F: drivers/pnp/isapnp/ F: include/linux/isapnp.h
isapnp code is very old and according to this link https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications from Wikipedia, even Windows Vista disabled ISA PnP by default. This change is in follow up to https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)