| Message ID | 20210617164212.584-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [1/5] ACPI: PM: s2idle: Use correct revision id | expand |
W dniu 17.06.2021 o 18:42, Mario Limonciello pisze: > From: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com> > > AMD spec mentions only revision 0. With this change, > device constraint list is populated properly. > > Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com> > --- > drivers/acpi/x86/s2idle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c > index 2d7ddb8a8cb6..da27c1c45c9f 100644 > --- a/drivers/acpi/x86/s2idle.c > +++ b/drivers/acpi/x86/s2idle.c > @@ -96,7 +96,7 @@ static void lpi_device_get_constraints_amd(void) > int i, j, k; > > out_obj = acpi_evaluate_dsm_typed(lps0_device_handle, &lps0_dsm_guid, > - 1, ACPI_LPS0_GET_DEVICE_CONSTRAINTS, > + rev_id, ACPI_LPS0_GET_DEVICE_CONSTRAINTS, > NULL, ACPI_TYPE_PACKAGE); > > if (!out_obj) > No regressions against [1] on my ASUS UM425IA. Suspend and resume still work, provided other relevant patches are applied. I am testing on Fedora 5.12 kernel [2]. Tested-by: Julian Sikorski <belegdol@gmail.com> [1] https://patchwork.kernel.org/project/linux-acpi/patch/20210317143842.786380-2-alexander.deucher@amd.com/ [2] https://gitlab.com/belegdol/kernel-ark/-/commits/fedora-5.12-s0ix-8-upstream-newnvme
diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index 2d7ddb8a8cb6..da27c1c45c9f 100644 --- a/drivers/acpi/x86/s2idle.c +++ b/drivers/acpi/x86/s2idle.c @@ -96,7 +96,7 @@ static void lpi_device_get_constraints_amd(void) int i, j, k; out_obj = acpi_evaluate_dsm_typed(lps0_device_handle, &lps0_dsm_guid, - 1, ACPI_LPS0_GET_DEVICE_CONSTRAINTS, + rev_id, ACPI_LPS0_GET_DEVICE_CONSTRAINTS, NULL, ACPI_TYPE_PACKAGE); if (!out_obj)