diff mbox series

[2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries

Message ID 20210916170054.136790-2-krzysztof.kozlowski@canonical.com (mailing list archive)
State Awaiting Upstream
Delegated to: Rafael Wysocki
Headers show
Series [1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS | expand

Commit Message

Krzysztof Kozlowski Sept. 16, 2021, 5 p.m. UTC
BRI0A49 and BDP3336 are already on the list.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/acpi/acpi_pnp.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Hans de Goede Sept. 21, 2021, 12:51 p.m. UTC | #1
Hi,

On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> BRI0A49 and BDP3336 are already on the list.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
driver. I'll leave picking this one up to you.

Regards,

Hans

> ---
>  drivers/acpi/acpi_pnp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> index 8f2dc176bb41..ffdcfcd4a10d 100644
> --- a/drivers/acpi/acpi_pnp.c
> +++ b/drivers/acpi/acpi_pnp.c
> @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
>  	{"BRI0A49"},		/* Boca Complete Ofc Communicator 14.4 Data-FAX */
>  	{"BRI1400"},		/* Boca Research 33,600 ACF Modem */
>  	{"BRI3400"},		/* Boca 33.6 Kbps Internal FD34FSVD */
> -	{"BRI0A49"},		/* Boca 33.6 Kbps Internal FD34FSVD */
> -	{"BDP3336"},		/* Best Data Products Inc. Smart One 336F PnP Modem */
>  	{"CPI4050"},		/* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
>  	{"CTL3001"},		/* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
>  	{"CTL3011"},		/* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
>
Rafael J. Wysocki Sept. 21, 2021, 1:08 p.m. UTC | #2
On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > BRI0A49 and BDP3336 are already on the list.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> driver. I'll leave picking this one up to you.

I'll pick it up, thanks!


> > ---
> >  drivers/acpi/acpi_pnp.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > --- a/drivers/acpi/acpi_pnp.c
> > +++ b/drivers/acpi/acpi_pnp.c
> > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> >       {"BRI0A49"},            /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> >       {"BRI1400"},            /* Boca Research 33,600 ACF Modem */
> >       {"BRI3400"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > -     {"BRI0A49"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > -     {"BDP3336"},            /* Best Data Products Inc. Smart One 336F PnP Modem */
> >       {"CPI4050"},            /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> >       {"CTL3001"},            /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> >       {"CTL3011"},            /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> >
>
Rafael J. Wysocki Sept. 24, 2021, 4:13 p.m. UTC | #3
On Tue, Sep 21, 2021 at 3:08 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > > BRI0A49 and BDP3336 are already on the list.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> > Thanks, patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> > driver. I'll leave picking this one up to you.
>
> I'll pick it up, thanks!

Applied as 5.16 material now, thanks!

> > > ---
> > >  drivers/acpi/acpi_pnp.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > > --- a/drivers/acpi/acpi_pnp.c
> > > +++ b/drivers/acpi/acpi_pnp.c
> > > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> > >       {"BRI0A49"},            /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> > >       {"BRI1400"},            /* Boca Research 33,600 ACF Modem */
> > >       {"BRI3400"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > > -     {"BRI0A49"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > > -     {"BDP3336"},            /* Best Data Products Inc. Smart One 336F PnP Modem */
> > >       {"CPI4050"},            /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> > >       {"CTL3001"},            /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> > >       {"CTL3011"},            /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> > >
> >
diff mbox series

Patch

diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
index 8f2dc176bb41..ffdcfcd4a10d 100644
--- a/drivers/acpi/acpi_pnp.c
+++ b/drivers/acpi/acpi_pnp.c
@@ -156,8 +156,6 @@  static const struct acpi_device_id acpi_pnp_device_ids[] = {
 	{"BRI0A49"},		/* Boca Complete Ofc Communicator 14.4 Data-FAX */
 	{"BRI1400"},		/* Boca Research 33,600 ACF Modem */
 	{"BRI3400"},		/* Boca 33.6 Kbps Internal FD34FSVD */
-	{"BRI0A49"},		/* Boca 33.6 Kbps Internal FD34FSVD */
-	{"BDP3336"},		/* Best Data Products Inc. Smart One 336F PnP Modem */
 	{"CPI4050"},		/* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
 	{"CTL3001"},		/* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
 	{"CTL3011"},		/* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */