diff mbox series

[v1,1/3] driver core: Provide device_match_acpi_handle() helper

Message ID 20211006171517.47393-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Superseded, archived
Headers show
Series [v1,1/3] driver core: Provide device_match_acpi_handle() helper | expand

Commit Message

Andy Shevchenko Oct. 6, 2021, 5:15 p.m. UTC
We have couple of users of this helper, make it available for them.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/base/core.c        | 6 ++++++
 include/linux/device/bus.h | 1 +
 2 files changed, 7 insertions(+)

Comments

Greg KH Oct. 6, 2021, 5:20 p.m. UTC | #1
On Wed, Oct 06, 2021 at 08:15:15PM +0300, Andy Shevchenko wrote:
> We have couple of users of this helper, make it available for them.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/base/core.c        | 6 ++++++
>  include/linux/device/bus.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index c4a2c97a21a2..18f1f6499246 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -4840,6 +4840,12 @@ int device_match_acpi_dev(struct device *dev, const void *adev)
>  }
>  EXPORT_SYMBOL(device_match_acpi_dev);
>  
> +int device_match_acpi_handle(struct device *dev, const void *handle)
> +{
> +	return ACPI_HANDLE(dev) == handle;
> +}
> +EXPORT_SYMBOL(device_match_acpi_dev);

Did you build this?

:(
Andy Shevchenko Oct. 6, 2021, 5:24 p.m. UTC | #2
On Wed, Oct 6, 2021 at 8:21 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Wed, Oct 06, 2021 at 08:15:15PM +0300, Andy Shevchenko wrote:
> > We have couple of users of this helper, make it available for them.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/base/core.c        | 6 ++++++
> >  include/linux/device/bus.h | 1 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index c4a2c97a21a2..18f1f6499246 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -4840,6 +4840,12 @@ int device_match_acpi_dev(struct device *dev, const void *adev)
> >  }
> >  EXPORT_SYMBOL(device_match_acpi_dev);
> >
> > +int device_match_acpi_handle(struct device *dev, const void *handle)
> > +{
> > +     return ACPI_HANDLE(dev) == handle;
> > +}
> > +EXPORT_SYMBOL(device_match_acpi_dev);
>
> Did you build this?

Yes, and it failed.

Sorry for the noise that I mistakenly sent the non-working version.
In fact, I typed 'a' literally thinking the word 'abort' for
git-send-email, what an irony!
diff mbox series

Patch

diff --git a/drivers/base/core.c b/drivers/base/core.c
index c4a2c97a21a2..18f1f6499246 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -4840,6 +4840,12 @@  int device_match_acpi_dev(struct device *dev, const void *adev)
 }
 EXPORT_SYMBOL(device_match_acpi_dev);
 
+int device_match_acpi_handle(struct device *dev, const void *handle)
+{
+	return ACPI_HANDLE(dev) == handle;
+}
+EXPORT_SYMBOL(device_match_acpi_dev);
+
 int device_match_any(struct device *dev, const void *unused)
 {
 	return 1;
diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h
index 062777a45a74..a039ab809753 100644
--- a/include/linux/device/bus.h
+++ b/include/linux/device/bus.h
@@ -143,6 +143,7 @@  int device_match_of_node(struct device *dev, const void *np);
 int device_match_fwnode(struct device *dev, const void *fwnode);
 int device_match_devt(struct device *dev, const void *pdevt);
 int device_match_acpi_dev(struct device *dev, const void *adev);
+int device_match_acpi_handle(struct device *dev, const void *handle);
 int device_match_any(struct device *dev, const void *unused);
 
 /* iterator helpers for buses */