| Message ID | 20211026190835.10697-3-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Let other drivers react to platform profile changes | expand |
Hi, On 10/26/21 21:08, Mario Limonciello wrote: > An upcoming change to platform profiles will export `platform_profile_get` > as a symbol that can be used by other drivers. Avoid the collision. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index e14fb5fa7324..8f067ac4e952 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -2169,8 +2169,8 @@ static ssize_t throttle_thermal_policy_store(struct device *dev, > static DEVICE_ATTR_RW(throttle_thermal_policy); > > /* Platform profile ***********************************************************/ > -static int platform_profile_get(struct platform_profile_handler *pprof, > - enum platform_profile_option *profile) > +static int asus_wmi_platform_profile_get(struct platform_profile_handler *pprof, > + enum platform_profile_option *profile) > { > struct asus_wmi *asus; > int tp; > @@ -2196,8 +2196,8 @@ static int platform_profile_get(struct platform_profile_handler *pprof, > return 0; > } > > -static int platform_profile_set(struct platform_profile_handler *pprof, > - enum platform_profile_option profile) > +static int asus_wmi_platform_profile_set(struct platform_profile_handler *pprof, > + enum platform_profile_option profile) > { > struct asus_wmi *asus; > int tp; > @@ -2236,8 +2236,8 @@ static int platform_profile_setup(struct asus_wmi *asus) > > dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n"); > > - asus->platform_profile_handler.profile_get = platform_profile_get; > - asus->platform_profile_handler.profile_set = platform_profile_set; > + asus->platform_profile_handler.profile_get = asus_wmi_platform_profile_get; > + asus->platform_profile_handler.profile_set = asus_wmi_platform_profile_set; > > set_bit(PLATFORM_PROFILE_QUIET, asus->platform_profile_handler.choices); > set_bit(PLATFORM_PROFILE_BALANCED, >
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index e14fb5fa7324..8f067ac4e952 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -2169,8 +2169,8 @@ static ssize_t throttle_thermal_policy_store(struct device *dev, static DEVICE_ATTR_RW(throttle_thermal_policy); /* Platform profile ***********************************************************/ -static int platform_profile_get(struct platform_profile_handler *pprof, - enum platform_profile_option *profile) +static int asus_wmi_platform_profile_get(struct platform_profile_handler *pprof, + enum platform_profile_option *profile) { struct asus_wmi *asus; int tp; @@ -2196,8 +2196,8 @@ static int platform_profile_get(struct platform_profile_handler *pprof, return 0; } -static int platform_profile_set(struct platform_profile_handler *pprof, - enum platform_profile_option profile) +static int asus_wmi_platform_profile_set(struct platform_profile_handler *pprof, + enum platform_profile_option profile) { struct asus_wmi *asus; int tp; @@ -2236,8 +2236,8 @@ static int platform_profile_setup(struct asus_wmi *asus) dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n"); - asus->platform_profile_handler.profile_get = platform_profile_get; - asus->platform_profile_handler.profile_set = platform_profile_set; + asus->platform_profile_handler.profile_get = asus_wmi_platform_profile_get; + asus->platform_profile_handler.profile_set = asus_wmi_platform_profile_set; set_bit(PLATFORM_PROFILE_QUIET, asus->platform_profile_handler.choices); set_bit(PLATFORM_PROFILE_BALANCED,
An upcoming change to platform profiles will export `platform_profile_get` as a symbol that can be used by other drivers. Avoid the collision. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/asus-wmi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)