| Message ID | 20211105041635.1481738-1-ishii.shuuichir@fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | acpi/tables: Add AEST in ACPI Table Definition | expand |
Ping? > -----Original Message----- > From: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > Sent: Friday, November 5, 2021 1:17 PM > To: rafael@kernel.org; lenb@kernel.org; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: lorenzo.pieralisi@arm.com; guohanjun@huawei.com; sudeep.holla@arm.com; > linux-arm-kernel@lists.infradead.org; Ishii, Shuuichirou/石井 周一郎 > <ishii.shuuichir@fujitsu.com> > Subject: [PATCH] acpi/tables: Add AEST in ACPI Table Definition > > When We added AEST using the Upgrading ACPI tables via initrd function, > the kernel could not recognize the AEST, so We added AEST the ACPI table > definition. > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > --- > drivers/acpi/tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index 71419eb16e09..2699bf7e21ab 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] > __initconst = { > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, > - ACPI_SIG_NHLT }; > + ACPI_SIG_NHLT, ACPI_SIG_AEST }; > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) > > -- > 2.27.0
On 2021/11/5 12:16, Shuuichirou Ishii wrote: > When We added AEST using the Upgrading ACPI tables via initrd function, > the kernel could not recognize the AEST, so We added AEST the ACPI table > definition. Maybe "so add the AEST table to the list to enable the table upgrade function." is better? > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > --- > drivers/acpi/tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index 71419eb16e09..2699bf7e21ab 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, > - ACPI_SIG_NHLT }; > + ACPI_SIG_NHLT, ACPI_SIG_AEST }; > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) Other than that, I'm fine with this patch. Acked-by: Hanjun Guo <guohanjun@huawei.com> Thanks Hanjun
Hi, Hanjun. Thanks for the comment. We apologize for the delay in replying due to my vacation. We understood this to be a point in response to the description of the patch comment. What do you think of the following description? When We added AEST using the Upgrading ACPI tables via initrd function, the kernel could not recognize the AEST, so added the AEST table to the list to enable the table upgrade function. Best regards, Shuuichirou. > -----Original Message----- > From: Hanjun Guo <guohanjun@huawei.com> > Sent: Friday, November 19, 2021 5:05 PM > To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@fujitsu.com>; > rafael@kernel.org; lenb@kernel.org; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: lorenzo.pieralisi@arm.com; sudeep.holla@arm.com; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] acpi/tables: Add AEST in ACPI Table Definition > > On 2021/11/5 12:16, Shuuichirou Ishii wrote: > > When We added AEST using the Upgrading ACPI tables via initrd > > function, the kernel could not recognize the AEST, so We added AEST > > the ACPI table definition. > > Maybe "so add the AEST table to the list to enable the table upgrade function." is > better? > > > > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > > --- > > drivers/acpi/tables.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index > > 71419eb16e09..2699bf7e21ab 100644 > > --- a/drivers/acpi/tables.c > > +++ b/drivers/acpi/tables.c > > @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] > __initconst = { > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, > > - ACPI_SIG_NHLT }; > > + ACPI_SIG_NHLT, ACPI_SIG_AEST }; > > > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) > > Other than that, I'm fine with this patch. > > Acked-by: Hanjun Guo <guohanjun@huawei.com> > > Thanks > Hanjun
On 2021/11/24 8:52, ishii.shuuichir@fujitsu.com wrote: > Hi, Hanjun. > > Thanks for the comment. > We apologize for the delay in replying due to my vacation. > > We understood this to be a point in response to the description of the patch comment. > What do you think of the following description? > > When We added AEST using the Upgrading ACPI tables via initrd function, > the kernel could not recognize the AEST, > so added the AEST table to the list to enable the table upgrade function. Looks good to me. Thanks Hanjun
Thanks for the review. We'd like to fix it and repost the v2 patch. Best regards, Shuuichirou > -----Original Message----- > From: Hanjun Guo <guohanjun@huawei.com> > Sent: Wednesday, November 24, 2021 4:11 PM > To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@fujitsu.com>; > rafael@kernel.org; lenb@kernel.org; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: lorenzo.pieralisi@arm.com; sudeep.holla@arm.com; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] acpi/tables: Add AEST in ACPI Table Definition > > On 2021/11/24 8:52, ishii.shuuichir@fujitsu.com wrote: > > Hi, Hanjun. > > > > Thanks for the comment. > > We apologize for the delay in replying due to my vacation. > > > > We understood this to be a point in response to the description of the patch > comment. > > What do you think of the following description? > > > > When We added AEST using the Upgrading ACPI tables via initrd > > function, the kernel could not recognize the AEST, so added the AEST > > table to the list to enable the table upgrade function. > > Looks good to me. > > Thanks > Hanjun
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 71419eb16e09..2699bf7e21ab 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AEST }; #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
When We added AEST using the Upgrading ACPI tables via initrd function, the kernel could not recognize the AEST, so We added AEST the ACPI table definition. Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> --- drivers/acpi/tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)