| Message ID | 20211110111640.62807-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [v1,1/1] ACPI: Replace kernel.h with the necessary inclusions | expand |
On Wed, Nov 10, 2021 at 01:16:40PM +0200, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. Anybody any comments on this? I really want to shrink kernel.h usage in headers rather sooner than later...
On Tue, Nov 23, 2021 at 5:31 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Wed, Nov 10, 2021 at 01:16:40PM +0200, Andy Shevchenko wrote: > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > > Anybody any comments on this? I really want to shrink kernel.h usage in > headers rather sooner than later... Patch applied as 5.17 material, thanks!
On Tue, Nov 23, 2021 at 07:03:21PM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 23, 2021 at 5:31 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Wed, Nov 10, 2021 at 01:16:40PM +0200, Andy Shevchenko wrote: > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > especially when there are circular dependencies are involved. > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > Anybody any comments on this? I really want to shrink kernel.h usage in > > headers rather sooner than later... > > Patch applied as 5.17 material, thanks! Thank you for the prompt acceptance!
diff --git a/include/acpi/acpi_numa.h b/include/acpi/acpi_numa.h index 68e4d80c1b32..b5f594754a9e 100644 --- a/include/acpi/acpi_numa.h +++ b/include/acpi/acpi_numa.h @@ -3,7 +3,6 @@ #define __ACPI_NUMA_H #ifdef CONFIG_ACPI_NUMA -#include <linux/kernel.h> #include <linux/numa.h> /* Proximity bitmap length */ diff --git a/include/acpi/processor.h b/include/acpi/processor.h index 683e124ad517..194027371928 100644 --- a/include/acpi/processor.h +++ b/include/acpi/processor.h @@ -2,11 +2,16 @@ #ifndef __ACPI_PROCESSOR_H #define __ACPI_PROCESSOR_H -#include <linux/kernel.h> #include <linux/cpu.h> #include <linux/cpufreq.h> #include <linux/pm_qos.h> +#include <linux/printk.h> +#include <linux/sched.h> +#include <linux/smp.h> #include <linux/thermal.h> +#include <linux/types.h> +#include <linux/workqueue.h> + #include <asm/acpi.h> #define ACPI_PROCESSOR_CLASS "processor"
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/acpi/acpi_numa.h | 1 - include/acpi/processor.h | 7 ++++++- 2 files changed, 6 insertions(+), 2 deletions(-)