| Message ID | 20211125083240.123131-1-ishii.shuuichir@fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] acpi/tables: Add AEST in ACPI Table Definition | expand |
On 2021/11/25 16:32, Shuuichirou Ishii wrote: > When We added AEST using the Upgrading ACPI tables via initrd function, > the kernel could not recognize the AEST, so added the AEST table to > the list to enable the table upgrade function. > > Change log: > v2 : The reason for committing in the commit log was not clear, > so it was pointed out and corrected. Please remove the change log in the commit message. > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > --- You can put the change log here then it will be removed when applying this patch. Thanks Hanjun
Hi, Hanjun. Thank you for your comment. We apologize for the basic mistake. We will try to fix it as follows, is it OK? --- Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition When We added AEST using the Upgrading ACPI tables via initrd function, the kernel could not recognize the AEST, so added the AEST table to the list to enable the table upgrade function. Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> --- v3 : Changed the location of the change log so that it does not disappear when the patch is applied. v2 : The reason for committing in the commit log was not clear, so it was pointed out and corrected. drivers/acpi/tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 71419eb16e09..2699bf7e21ab 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AEST }; #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header) -- Best regards, Shuuichrou. > -----Original Message----- > From: Hanjun Guo <guohanjun@huawei.com> > Sent: Saturday, November 27, 2021 12:01 PM > To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@fujitsu.com>; > rafael@kernel.org; lenb@kernel.org; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org; lorenzo.pieralisi@arm.com; > sudeep.holla@arm.com > Cc: linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition > > On 2021/11/25 16:32, Shuuichirou Ishii wrote: > > When We added AEST using the Upgrading ACPI tables via initrd > > function, the kernel could not recognize the AEST, so added the AEST > > table to the list to enable the table upgrade function. > > > > Change log: > > v2 : The reason for committing in the commit log was not clear, > > so it was pointed out and corrected. > > Please remove the change log in the commit message. > > > > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > > --- > > You can put the change log here then it will be removed when applying this patch. > > Thanks > Hanjun
On 2021/11/29 7:54, ishii.shuuichir@fujitsu.com wrote: > Hi, Hanjun. > > Thank you for your comment. > We apologize for the basic mistake. > > We will try to fix it as follows, is it OK? > > --- > Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition > > When We added AEST using the Upgrading ACPI tables via initrd function, > the kernel could not recognize the AEST, so added the AEST table to > the list to enable the table upgrade function. > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > --- > v3 : Changed the location of the change log so that it does not > disappear when the patch is applied. > > v2 : The reason for committing in the commit log was not clear, > so it was pointed out and corrected. Looks good to me. Thanks Hanjun
Thanks for the review. We will repost the patch to reflect the contents. Best regards, Shuuichirou. > -----Original Message----- > From: Hanjun Guo <guohanjun@huawei.com> > Sent: Monday, November 29, 2021 10:01 AM > To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@fujitsu.com>; > rafael@kernel.org; lenb@kernel.org; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org; lorenzo.pieralisi@arm.com; > sudeep.holla@arm.com > Cc: linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition > > On 2021/11/29 7:54, ishii.shuuichir@fujitsu.com wrote: > > Hi, Hanjun. > > > > Thank you for your comment. > > We apologize for the basic mistake. > > > > We will try to fix it as follows, is it OK? > > > > --- > > Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition > > > > When We added AEST using the Upgrading ACPI tables via initrd > > function, the kernel could not recognize the AEST, so added the AEST > > table to the list to enable the table upgrade function. > > > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> > > --- > > v3 : Changed the location of the change log so that it does not > > disappear when the patch is applied. > > > > v2 : The reason for committing in the commit log was not clear, > > so it was pointed out and corrected. > > Looks good to me. > > Thanks > Hanjun
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 71419eb16e09..2699bf7e21ab 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = { ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT, - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AEST }; #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
When We added AEST using the Upgrading ACPI tables via initrd function, the kernel could not recognize the AEST, so added the AEST table to the list to enable the table upgrade function. Change log: v2 : The reason for committing in the commit log was not clear, so it was pointed out and corrected. Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com> --- drivers/acpi/tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)