| Message ID | 20220608144517.380962958@infradead.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | cpuidle,rcu: Cleanup the mess | expand |
On Wed, Jun 08, 2022 at 04:27:46PM +0200, Peter Zijlstra wrote: > Ever since commit d3afc7f12987 ("arm64: Allow IPIs to be handled as > normal interrupts") this function is called in regular IRQ context. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> [adding Marc since he authored that commit] Makes sense to me: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > arch/arm64/kernel/smp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -865,7 +865,7 @@ static void do_handle_IPI(int ipinr) > unsigned int cpu = smp_processor_id(); > > if ((unsigned)ipinr < NR_IPI) > - trace_ipi_entry_rcuidle(ipi_types[ipinr]); > + trace_ipi_entry(ipi_types[ipinr]); > > switch (ipinr) { > case IPI_RESCHEDULE: > @@ -914,7 +914,7 @@ static void do_handle_IPI(int ipinr) > } > > if ((unsigned)ipinr < NR_IPI) > - trace_ipi_exit_rcuidle(ipi_types[ipinr]); > + trace_ipi_exit(ipi_types[ipinr]); > } > > static irqreturn_t ipi_handler(int irq, void *data) > >
On Tue, 14 Jun 2022 17:24:48 +0100, Mark Rutland <mark.rutland@arm.com> wrote: > > On Wed, Jun 08, 2022 at 04:27:46PM +0200, Peter Zijlstra wrote: > > Ever since commit d3afc7f12987 ("arm64: Allow IPIs to be handled as > > normal interrupts") this function is called in regular IRQ context. > > > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > [adding Marc since he authored that commit] > > Makes sense to me: > > Acked-by: Mark Rutland <mark.rutland@arm.com> > > Mark. > > > --- > > arch/arm64/kernel/smp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/arch/arm64/kernel/smp.c > > +++ b/arch/arm64/kernel/smp.c > > @@ -865,7 +865,7 @@ static void do_handle_IPI(int ipinr) > > unsigned int cpu = smp_processor_id(); > > > > if ((unsigned)ipinr < NR_IPI) > > - trace_ipi_entry_rcuidle(ipi_types[ipinr]); > > + trace_ipi_entry(ipi_types[ipinr]); > > > > switch (ipinr) { > > case IPI_RESCHEDULE: > > @@ -914,7 +914,7 @@ static void do_handle_IPI(int ipinr) > > } > > > > if ((unsigned)ipinr < NR_IPI) > > - trace_ipi_exit_rcuidle(ipi_types[ipinr]); > > + trace_ipi_exit(ipi_types[ipinr]); > > } > > > > static irqreturn_t ipi_handler(int irq, void *data) Acked-by: Marc Zyngier <maz@kernel.org> M.
--- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -865,7 +865,7 @@ static void do_handle_IPI(int ipinr) unsigned int cpu = smp_processor_id(); if ((unsigned)ipinr < NR_IPI) - trace_ipi_entry_rcuidle(ipi_types[ipinr]); + trace_ipi_entry(ipi_types[ipinr]); switch (ipinr) { case IPI_RESCHEDULE: @@ -914,7 +914,7 @@ static void do_handle_IPI(int ipinr) } if ((unsigned)ipinr < NR_IPI) - trace_ipi_exit_rcuidle(ipi_types[ipinr]); + trace_ipi_exit(ipi_types[ipinr]); } static irqreturn_t ipi_handler(int irq, void *data)
Ever since commit d3afc7f12987 ("arm64: Allow IPIs to be handled as normal interrupts") this function is called in regular IRQ context. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> --- arch/arm64/kernel/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)