diff mbox series

ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA

Message ID 20230411183144.6932-1-pmenzel@molgen.mpg.de (mailing list archive)
State Mainlined, archived
Headers show
Series ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA | expand

Commit Message

Paul Menzel April 11, 2023, 6:31 p.m. UTC
Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
ActiveLow while the kernel overrides it to Edge_High.

    $ sudo dmesg | grep DMI
    DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
    $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
                    IRQ (Level, ActiveLow, Exclusive, )
                        {1}

This prevents the keyboard from working. To fix this issue, add this laptop
to the skip_override_table so that the kernel does not override IRQ 1.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
Cc: lore982@yahoo.com
Cc: Tamim Khan <tamim@fusetak.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rafael J. Wysocki April 11, 2023, 6:54 p.m. UTC | #1
On Tue, Apr 11, 2023 at 8:32 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
> ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
>
>     $ sudo dmesg | grep DMI
>     DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
>     $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
>                     IRQ (Level, ActiveLow, Exclusive, )
>                         {1}
>
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
> Cc: lore982@yahoo.com
> Cc: Tamim Khan <tamim@fusetak.com>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index a222bda7e15b..cade3a9e38bb 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
>                 },
>         },
> +       {
> +               .ident = "Asus ExpertBook B1502CBA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "B1502CBA"),
> +               },
> +       },
>         {
>                 .ident = "Asus ExpertBook B2402CBA",
>                 .matches = {
> --

Applied as 6.3-rc material, thanks!
Paul Menzel April 12, 2023, 1:52 p.m. UTC | #2
Dear Linux folks,


Just for the record, I am adding the Tested-by line. Lorenzo tried to 
send it themselves, but even text/plain were rejected by LKML as they 
are using Yahoo Mail.

     linux-kernel@vger.kernel.org>: host 23.128.96.18[23.128.96.18] 
said: 553 5.7.1
         Hello [23.128.96.19], for your MAIL FROM address 
<lore982@yahoo.com> policy
         analysis reported: Your address is not liked source for email 
(in reply to
         MAIL FROM command)

Am 11.04.23 um 20:31 schrieb Paul Menzel:
> Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
> ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
> 
>      $ sudo dmesg | grep DMI
>      DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
>      $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
>                      IRQ (Level, ActiveLow, Exclusive, )
>                          {1}
> 
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
> Cc: lore982@yahoo.com
> Cc: Tamim Khan <tamim@fusetak.com>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Tested-by: Lorenzo Grasso <lore982@yahoo.com>

[…]


Kind regards,

Paul
diff mbox series

Patch

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index a222bda7e15b..cade3a9e38bb 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -432,6 +432,13 @@  static const struct dmi_system_id asus_laptop[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
 		},
 	},
+	{
+		.ident = "Asus ExpertBook B1502CBA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "B1502CBA"),
+		},
+	},
 	{
 		.ident = "Asus ExpertBook B2402CBA",
 		.matches = {