| Message ID | 20230621035102.13463-4-avadhut.naik@amd.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add support for Vendor Defined Error Types in Einj Module | expand |
On Wed, Jun 21, 2023 at 03:51:01AM +0000, Avadhut Naik wrote: > From: Avadhut Naik <Avadhut.Naik@amd.com> > > The debugfs_create_blob() function has been used to create read-only binary > blobs in debugfs. The function filters out permissions, other than S_IRUSR, > S_IRGRP and S_IROTH, provided while creating the blobs. > > The very behavior though is being changed through previous patch in the > series (fs: debugfs: Add write functionality to debugfs blobs) which makes > the binary blobs writable. > > As such, rectify the permissions of panicinfo file to ensure it remains > read-only. > > Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c index c876120e0ebc..4428dcbd2a68 100644 --- a/drivers/platform/chrome/cros_ec_debugfs.c +++ b/drivers/platform/chrome/cros_ec_debugfs.c @@ -454,7 +454,7 @@ static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info) debug_info->panicinfo_blob.data = data; debug_info->panicinfo_blob.size = ret; - debugfs_create_blob("panicinfo", S_IFREG | 0444, debug_info->dir, + debugfs_create_blob("panicinfo", 0444, debug_info->dir, &debug_info->panicinfo_blob); return 0;