From patchwork Wed Sep 20 11:52:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangkaiyuan X-Patchwork-Id: 13392570 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160C0CE79D1 for ; Wed, 20 Sep 2023 11:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234470AbjITLx3 (ORCPT ); Wed, 20 Sep 2023 07:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234769AbjITLx0 (ORCPT ); Wed, 20 Sep 2023 07:53:26 -0400 X-Greylist: delayed 62 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 20 Sep 2023 04:53:18 PDT Received: from ssh247.corpemail.net (ssh247.corpemail.net [210.51.61.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7C4B4; Wed, 20 Sep 2023 04:53:18 -0700 (PDT) Received: from ssh247.corpemail.net by ssh247.corpemail.net ((D)) with ASMTP (SSL) id QMV00011; Wed, 20 Sep 2023 19:52:11 +0800 Received: from localhost.localdomain (10.200.104.15) by jtjnmail201621.home.langchao.com (10.100.2.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 19:52:10 +0800 From: wangkaiyuan To: , CC: , , wangkaiyuan Subject: [PATCH] aoe: Use helper function IS_ERR_OR_NULL() Date: Wed, 20 Sep 2023 19:52:08 +0800 Message-ID: <20230920115208.2733-1-wangkaiyuan@inspur.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Originating-IP: [10.200.104.15] X-ClientProxiedBy: Jtjnmail201618.home.langchao.com (10.100.2.18) To jtjnmail201621.home.langchao.com (10.100.2.21) tUid: 202392019521190ae24927acef3f0f1ae5d15cc908102 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Use IS_ERR_OR_NULL() to detect an error pointer or a null pointer open-coding to simplify the code. Signed-off-by: wangkaiyuan --- drivers/block/aoe/aoecmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index d7317425be51..94a7aa6cf58a 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1256,7 +1256,7 @@ aoe_ktstart(struct ktstate *k) init_completion(&k->rendez); task = kthread_run(kthread, k, "%s", k->name); - if (task == NULL || IS_ERR(task)) + if (IS_ERR_OR_NULL(backend)) return -ENOMEM; k->task = task; wait_for_completion(&k->rendez); /* allow kthread to start */