Message ID | 20231023053530.5525-5-raag.jadav@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Series | Refine _UID references across kernel | expand |
On Mon, Oct 23, 2023 at 11:05:28AM +0530, Raag Jadav wrote: > Convert manual _UID references to use the standard ACPI helper. > Signed-off-by: Raag Jadav <raag.jadav@intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Please, drop this tag, since I disagree with patch 1 implementation.
diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c index 63d834dd3811..bc65ebfcdf76 100644 --- a/drivers/acpi/x86/utils.c +++ b/drivers/acpi/x86/utils.c @@ -184,8 +184,7 @@ bool acpi_device_override_status(struct acpi_device *adev, unsigned long long *s if (acpi_match_device_ids(adev, override_status_ids[i].hid)) continue; - if (!adev->pnp.unique_id || - strcmp(adev->pnp.unique_id, override_status_ids[i].uid)) + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid)) continue; }