| Message ID | 20240517091557.25800-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | arch: Fix name collision with ACPI's video.o | expand |
Hi, On 5/17/24 11:14 AM, Thomas Zimmermann wrote: > Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") > renames the video source files under arch/ such that they do not > refer to fbdev any longer. The new files named video.o conflict with > ACPI's video.ko module. Modprobing the ACPI module can then fail with > warnings about missing symbols, as shown below. > > (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_unregister (err -2) > (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_register_backlight (err -2) > (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol __acpi_video_get_backlight_type (err -2) > (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_register (err -2) > > Fix the issue by renaming the architecture's video.o to video-common.o. > > Reported-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> > Closes: https://lore.kernel.org/intel-gfx/9dcac6e9-a3bf-4ace-bbdc-f697f767f9e0@suse.de/T/#t > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 2fd001cd3600 ("arch: Rename fbdev header and source files") > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-arch@vger.kernel.org > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > arch/sparc/video/Makefile | 2 +- > arch/sparc/video/{video.c => video-common.c} | 0 > arch/x86/video/Makefile | 2 +- > arch/x86/video/{video.c => video-common.c} | 0 > 4 files changed, 2 insertions(+), 2 deletions(-) > rename arch/sparc/video/{video.c => video-common.c} (100%) > rename arch/x86/video/{video.c => video-common.c} (100%) > > diff --git a/arch/sparc/video/Makefile b/arch/sparc/video/Makefile > index fdf83a408d750..dcfbe7a5912c0 100644 > --- a/arch/sparc/video/Makefile > +++ b/arch/sparc/video/Makefile > @@ -1,3 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -obj-y += video.o > +obj-y += video-common.o > diff --git a/arch/sparc/video/video.c b/arch/sparc/video/video-common.c > similarity index 100% > rename from arch/sparc/video/video.c > rename to arch/sparc/video/video-common.c > diff --git a/arch/x86/video/Makefile b/arch/x86/video/Makefile > index fdf83a408d750..dcfbe7a5912c0 100644 > --- a/arch/x86/video/Makefile > +++ b/arch/x86/video/Makefile > @@ -1,3 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -obj-y += video.o > +obj-y += video-common.o > diff --git a/arch/x86/video/video.c b/arch/x86/video/video-common.c > similarity index 100% > rename from arch/x86/video/video.c > rename to arch/x86/video/video-common.c
diff --git a/arch/sparc/video/Makefile b/arch/sparc/video/Makefile index fdf83a408d750..dcfbe7a5912c0 100644 --- a/arch/sparc/video/Makefile +++ b/arch/sparc/video/Makefile @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-y += video.o +obj-y += video-common.o diff --git a/arch/sparc/video/video.c b/arch/sparc/video/video-common.c similarity index 100% rename from arch/sparc/video/video.c rename to arch/sparc/video/video-common.c diff --git a/arch/x86/video/Makefile b/arch/x86/video/Makefile index fdf83a408d750..dcfbe7a5912c0 100644 --- a/arch/x86/video/Makefile +++ b/arch/x86/video/Makefile @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-y += video.o +obj-y += video-common.o diff --git a/arch/x86/video/video.c b/arch/x86/video/video-common.c similarity index 100% rename from arch/x86/video/video.c rename to arch/x86/video/video-common.c
Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") renames the video source files under arch/ such that they do not refer to fbdev any longer. The new files named video.o conflict with ACPI's video.ko module. Modprobing the ACPI module can then fail with warnings about missing symbols, as shown below. (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_unregister (err -2) (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_register_backlight (err -2) (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol __acpi_video_get_backlight_type (err -2) (i915_selftest:1107) igt_kmod-WARNING: i915: Unknown symbol acpi_video_register (err -2) Fix the issue by renaming the architecture's video.o to video-common.o. Reported-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Closes: https://lore.kernel.org/intel-gfx/9dcac6e9-a3bf-4ace-bbdc-f697f767f9e0@suse.de/T/#t Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 2fd001cd3600 ("arch: Rename fbdev header and source files") Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-arch@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- arch/sparc/video/Makefile | 2 +- arch/sparc/video/{video.c => video-common.c} | 0 arch/x86/video/Makefile | 2 +- arch/x86/video/{video.c => video-common.c} | 0 4 files changed, 2 insertions(+), 2 deletions(-) rename arch/sparc/video/{video.c => video-common.c} (100%) rename arch/x86/video/{video.c => video-common.c} (100%)