| Message ID | 20240606022845.189710-1-ying.huang@intel.com (mailing list archive) |
|---|---|
| State | In Next |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | acpi,hmat: Use ACCESS_COORDINATE_CPU when appropriate | expand |
On Thu, 6 Jun 2024 10:28:45 +0800 Huang Ying <ying.huang@intel.com> wrote: > To improve the readability of the code via replacing the magic number > "1" with ACCESS_COORDINATE_CPU when appropriate. No functionality > change. > > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Bharata B Rao <bharata@amd.com> > Cc: Alistair Popple <apopple@nvidia.com> > Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Good to clean this up. Thanks! Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/acpi/numa/hmat.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 2c8ccc91ebe6..febd9e51350b 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -408,7 +408,7 @@ static __init void hmat_update_target(unsigned int tgt_pxm, unsigned int init_px > if (target && target->processor_pxm == init_pxm) { > hmat_update_target_access(target, type, value, > ACCESS_COORDINATE_LOCAL); > - /* If the node has a CPU, update access 1 */ > + /* If the node has a CPU, update access ACCESS_COORDINATE_CPU */ > if (node_state(pxm_to_node(init_pxm), N_CPU)) > hmat_update_target_access(target, type, value, > ACCESS_COORDINATE_CPU); > @@ -948,7 +948,7 @@ static int hmat_set_default_dram_perf(void) > target = find_mem_target(pxm); > if (!target) > continue; > - attrs = &target->coord[1]; > + attrs = &target->coord[ACCESS_COORDINATE_CPU]; > rc = mt_set_default_dram_perf(nid, attrs, "ACPI HMAT"); > if (rc) > return rc; > @@ -975,7 +975,7 @@ static int hmat_calculate_adistance(struct notifier_block *self, > hmat_update_target_attrs(target, p_nodes, ACCESS_COORDINATE_CPU); > mutex_unlock(&target_lock); > > - perf = &target->coord[1]; > + perf = &target->coord[ACCESS_COORDINATE_CPU]; > > if (mt_perf_to_adistance(perf, adist)) > return NOTIFY_OK;
On 6/5/24 7:28 PM, Huang Ying wrote: > To improve the readability of the code via replacing the magic number > "1" with ACCESS_COORDINATE_CPU when appropriate. No functionality > change. > > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Bharata B Rao <bharata@amd.com> > Cc: Alistair Popple <apopple@nvidia.com> > Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Thanks for this. Looks like I missed a few. Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/acpi/numa/hmat.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 2c8ccc91ebe6..febd9e51350b 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -408,7 +408,7 @@ static __init void hmat_update_target(unsigned int tgt_pxm, unsigned int init_px > if (target && target->processor_pxm == init_pxm) { > hmat_update_target_access(target, type, value, > ACCESS_COORDINATE_LOCAL); > - /* If the node has a CPU, update access 1 */ > + /* If the node has a CPU, update access ACCESS_COORDINATE_CPU */ > if (node_state(pxm_to_node(init_pxm), N_CPU)) > hmat_update_target_access(target, type, value, > ACCESS_COORDINATE_CPU); > @@ -948,7 +948,7 @@ static int hmat_set_default_dram_perf(void) > target = find_mem_target(pxm); > if (!target) > continue; > - attrs = &target->coord[1]; > + attrs = &target->coord[ACCESS_COORDINATE_CPU]; > rc = mt_set_default_dram_perf(nid, attrs, "ACPI HMAT"); > if (rc) > return rc; > @@ -975,7 +975,7 @@ static int hmat_calculate_adistance(struct notifier_block *self, > hmat_update_target_attrs(target, p_nodes, ACCESS_COORDINATE_CPU); > mutex_unlock(&target_lock); > > - perf = &target->coord[1]; > + perf = &target->coord[ACCESS_COORDINATE_CPU]; > > if (mt_perf_to_adistance(perf, adist)) > return NOTIFY_OK;
diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c index 2c8ccc91ebe6..febd9e51350b 100644 --- a/drivers/acpi/numa/hmat.c +++ b/drivers/acpi/numa/hmat.c @@ -408,7 +408,7 @@ static __init void hmat_update_target(unsigned int tgt_pxm, unsigned int init_px if (target && target->processor_pxm == init_pxm) { hmat_update_target_access(target, type, value, ACCESS_COORDINATE_LOCAL); - /* If the node has a CPU, update access 1 */ + /* If the node has a CPU, update access ACCESS_COORDINATE_CPU */ if (node_state(pxm_to_node(init_pxm), N_CPU)) hmat_update_target_access(target, type, value, ACCESS_COORDINATE_CPU); @@ -948,7 +948,7 @@ static int hmat_set_default_dram_perf(void) target = find_mem_target(pxm); if (!target) continue; - attrs = &target->coord[1]; + attrs = &target->coord[ACCESS_COORDINATE_CPU]; rc = mt_set_default_dram_perf(nid, attrs, "ACPI HMAT"); if (rc) return rc; @@ -975,7 +975,7 @@ static int hmat_calculate_adistance(struct notifier_block *self, hmat_update_target_attrs(target, p_nodes, ACCESS_COORDINATE_CPU); mutex_unlock(&target_lock); - perf = &target->coord[1]; + perf = &target->coord[ACCESS_COORDINATE_CPU]; if (mt_perf_to_adistance(perf, adist)) return NOTIFY_OK;
To improve the readability of the code via replacing the magic number "1" with ACCESS_COORDINATE_CPU when appropriate. No functionality change. Signed-off-by: "Huang, Ying" <ying.huang@intel.com> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Dave Jiang <dave.jiang@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Bharata B Rao <bharata@amd.com> Cc: Alistair Popple <apopple@nvidia.com> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- drivers/acpi/numa/hmat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)