diff mbox series

[v1] ACPI: APD: Add AMDI0015 as platform device

Message ID 20240718152324.3449253-1-Shyam-sundar.S-k@amd.com (mailing list archive)
State Superseded, archived
Headers show
Series [v1] ACPI: APD: Add AMDI0015 as platform device | expand

Commit Message

Shyam Sundar S K July 18, 2024, 3:23 p.m. UTC 
Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
for the I3C device on the latest AMD platforms.

Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
 drivers/acpi/acpi_apd.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Shyam Sundar S K Aug. 9, 2024, 3:38 p.m. UTC | #1 
+Andy

On 7/18/2024 20:53, Shyam Sundar S K wrote:
> Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
> for the I3C device on the latest AMD platforms.
> 
> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/acpi/acpi_apd.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 80f945cbec8a..6c502268879e 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -118,6 +118,11 @@ static const struct apd_device_desc wt_i2c_desc = {
>  	.fixed_clk_rate = 150000000,
>  };
>  
> +static const struct apd_device_desc wt_i3c_desc = {
> +	.setup = acpi_apd_setup,
> +	.fixed_clk_rate = 125000000,
> +};
> +
>  static struct property_entry uart_properties[] = {
>  	PROPERTY_ENTRY_U32("reg-io-width", 4),
>  	PROPERTY_ENTRY_U32("reg-shift", 2),
> @@ -232,6 +237,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>  	{ "AMD0040", APD_ADDR(fch_misc_desc)},
>  	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
>  	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
> +	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },

FYI..

AMDI0015 is for MIPI I3C (we call it I3C legacy) version of the
implementation.

and.. MIPI0100 is for HCI based implementation of the MIPI I3C
Specification.

Thanks,
Shyam

>  	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
>  	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
>  	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
Andy Shevchenko Aug. 9, 2024, 3:59 p.m. UTC | #2 
On Fri, Aug 09, 2024 at 09:08:22PM +0530, Shyam Sundar S K wrote:
> +Andy
> 
> On 7/18/2024 20:53, Shyam Sundar S K wrote:
> > Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
> > for the I3C device on the latest AMD platforms.

...

> >  	{ "AMD0040", APD_ADDR(fch_misc_desc)},
> >  	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
> >  	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
> > +	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },

Please, keep it sorted.

...

> FYI..

Thanks!

> AMDI0015 is for MIPI I3C (we call it I3C legacy) version of the
> implementation.
> 
> and.. MIPI0100 is for HCI based implementation of the MIPI I3C
> Specification.

This is fine as long as there is no collision, i.e. if a new (HCI I3C _HID is
required the new one should be allocated).
diff mbox series

Patch

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 80f945cbec8a..6c502268879e 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -118,6 +118,11 @@  static const struct apd_device_desc wt_i2c_desc = {
 	.fixed_clk_rate = 150000000,
 };
 
+static const struct apd_device_desc wt_i3c_desc = {
+	.setup = acpi_apd_setup,
+	.fixed_clk_rate = 125000000,
+};
+
 static struct property_entry uart_properties[] = {
 	PROPERTY_ENTRY_U32("reg-io-width", 4),
 	PROPERTY_ENTRY_U32("reg-shift", 2),
@@ -232,6 +237,7 @@  static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "AMD0040", APD_ADDR(fch_misc_desc)},
 	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
 	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
+	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
 	{ "AMDI0022", APD_ADDR(cz_uart_desc) },
 	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },