| Message ID | 20241210-fix-ipu-v3-1-00e409c84a6c@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI) | expand |
Hi Ricardo, On Tue, Dec 10, 2024 at 07:55:58PM +0000, Ricardo Ribalda wrote: > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > throws the following smatch warning: > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > Fix it by replacing the condition. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> I've picked this to my tree and I'll take the last one, too, once the rest reaches the media tree.
On Tue, 10 Dec 2024 at 22:04, Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Ricardo, > > On Tue, Dec 10, 2024 at 07:55:58PM +0000, Ricardo Ribalda wrote: > > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > > throws the following smatch warning: > > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > > > Fix it by replacing the condition. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > I've picked this to my tree and I'll take the last one, too, once the rest > reaches the media tree. Thanks! If you do not mind, I will keep sending 1/7 when I send v3, to make sure it is tested by the CI. I will mark it as duplicate in patchwork. Thanks! > > -- > Regards, > > Sakari Ailus
Em Tue, 10 Dec 2024 19:55:58 +0000 Ricardo Ribalda <ribalda@chromium.org> escreveu: > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > throws the following smatch warning: > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > Fix it by replacing the condition. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/pci/intel/ipu-bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > index a0e9a71580b5..be82bc3e27d0 100644 > --- a/drivers/media/pci/intel/ipu-bridge.c > +++ b/drivers/media/pci/intel/ipu-bridge.c > @@ -774,7 +774,7 @@ static int ipu_bridge_ivsc_is_ready(void) > > for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) { > #else > - while (true) { > + while (false) { > sensor_adev = NULL; > #endif The better would be to just remove all #if and handle ACPI compatibility with COMPILE_TEST inside acpi headers. Besides that, t sounds that patch 2 makes this hack unneeded, as you added a false check at the for macro: #define for_each_acpi_dev_match(adev, hid, uid, hrv) \ for (adev = NULL; false && (hid) && (uid) && (hrv);) Please place only one set of subsystem maintainers at the To: line, directing to the one(s) you expect to merge this series. In this particular case, the one to be added should be the ACPI maintainers. Regards, Mauro
Hi Mauro On Wed, 11 Dec 2024 at 09:15, Mauro Carvalho Chehab <maurochehab@gmail.com> wrote: > > Em Tue, 10 Dec 2024 19:55:58 +0000 > Ricardo Ribalda <ribalda@chromium.org> escreveu: > > > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > > throws the following smatch warning: > > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > > > Fix it by replacing the condition. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > --- > > drivers/media/pci/intel/ipu-bridge.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > > index a0e9a71580b5..be82bc3e27d0 100644 > > --- a/drivers/media/pci/intel/ipu-bridge.c > > +++ b/drivers/media/pci/intel/ipu-bridge.c > > @@ -774,7 +774,7 @@ static int ipu_bridge_ivsc_is_ready(void) > > > > for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) { > > #else > > - while (true) { > > + while (false) { > > sensor_adev = NULL; > > #endif > > The better would be to just remove all #if and handle ACPI compatibility > with COMPILE_TEST inside acpi headers. > > Besides that, t sounds that patch 2 makes this hack unneeded, as you added > a false check at the for macro: > > #define for_each_acpi_dev_match(adev, hid, uid, hrv) \ > for (adev = NULL; false && (hid) && (uid) && (hrv);) > > Please place only one set of subsystem maintainers at the To: line, > directing to the one(s) you expect to merge this series. > > In this particular case, the one to be added should be the ACPI > maintainers. The plan was to land 1/7 via the media tree with a PR from Sakari soonish. I believe he has already picked it on his tree. I will remove you from Cc in the next version thanks :) > > Regards, > Mauro
Em Tue, 10 Dec 2024 21:03:56 +0000 Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > Hi Ricardo, > > On Tue, Dec 10, 2024 at 07:55:58PM +0000, Ricardo Ribalda wrote: > > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > > throws the following smatch warning: > > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > > > Fix it by replacing the condition. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > I've picked this to my tree and I'll take the last one, too, once the rest > reaches the media tree. I prefer not merging it via media tree, except if we get an explicit ack to do so from ACPI maintainers, as most of the stuff here are at ACPI headers. Thanks, Mauro
Em Tue, 10 Dec 2024 22:27:32 +0100 Ricardo Ribalda <ribalda@chromium.org> escreveu: > On Tue, 10 Dec 2024 at 22:04, Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > > > Hi Ricardo, > > > > On Tue, Dec 10, 2024 at 07:55:58PM +0000, Ricardo Ribalda wrote: > > > One of the quirks that we introduced to build with !ACPI && COMPILE_TEST > > > throws the following smatch warning: > > > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > > > > > Fix it by replacing the condition. > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > > Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > > > I've picked this to my tree and I'll take the last one, too, once the rest > > reaches the media tree. > > Thanks! > > If you do not mind, I will keep sending 1/7 when I send v3, to make > sure it is tested by the CI. I will mark it as duplicate in patchwork. Patches should not be designed to make CI happy, but to ensure that we have a nice history at Kernel's log. Patch 1/7 shall be merged with 7/7, as you're just artificially breaking it into without a good reason, making CI happy, but reviewers and maintainers unhappy :-) Thanks, Mauro
diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c index a0e9a71580b5..be82bc3e27d0 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -774,7 +774,7 @@ static int ipu_bridge_ivsc_is_ready(void) for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) { #else - while (true) { + while (false) { sensor_adev = NULL; #endif if (!ACPI_PTR(sensor_adev->status.enabled))
One of the quirks that we introduced to build with !ACPI && COMPILE_TEST throws the following smatch warning: drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented Fix it by replacing the condition. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/media/pci/intel/ipu-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)