From patchwork Thu Dec 12 00:31:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 13904550 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F859CA5B for ; Thu, 12 Dec 2024 00:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963532; cv=none; b=TAoQtvwDXn+nRjBDF6VKFxUNdZQDqxePNihKq9+Jdcy91n8vho3TwuCN8yTCQewTcc9gp1ZNjm+blU5+PiW0TS0EwQ7sRXSW4k7RdvUJ4KBLLZk0jOpsLe+2/m4p93syqv8h5wepqc0vLnzqMKZdaT+ohTlqDzy9AQ50JvJ+G1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963532; c=relaxed/simple; bh=Kd6noYu5kKaYuzY2in9AHzWwTWDE6GDZOmHXqRdwZq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S4amkMXsXfgMqxTJHq0zOk8soGWKik5/mVCJ5IQpFyK173T7IDWuHbpIcq/sas3iGA9CQyUXC2y3RJpz/D+CLebvv9IO90vszaN5jOxsSFO+T55f3z8nNdDsSMCHmKA1nyXOPcKp3UYRi0KhQcoBmh0Zg2QSuHPFFbiA38CMQhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Pp9QeeFR; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Pp9QeeFR" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-216426b0865so372415ad.0 for ; Wed, 11 Dec 2024 16:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963529; x=1734568329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=Pp9QeeFRfnoMlCiiurrzdJkSvsudEVGzZvOCuEawQ413F15UbpFsEzWHAww5e5YBX5 fzCWEP/KFSJ7RgviBE8CpnHpjfbV+sw+1ub8DhqAACBAn4fWZ+CAKp7aZeRXNGOvM20T DtB+S+i+IszUzirH0wpt7FPHHPGK8XgUO9eLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963529; x=1734568329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=tYME3BrjKpdAI/iFNH0QOTsag0ejxnfVU+AmFP0oia1bj3PffPkZr5deallnlrxXps BZKbcaOlcXd4IP2tIm6odc+e19EPsBfDiFTHFdTZvy0U6G/ytRwKl9zOoUeUSkpHqkOw J0OkEZZrL0XYBYMB//qItubUHgPUsgRp/zoKaAfngMIQ0Ih82L4zDu3sQBhiuQyo1wRI SkOdfVBn+b1gRFX9CcDoTQE5sj7KmpOQM8bC0syNS1a8aCKgzFHC0Cq6R1qWJJ62To88 9kqIRwauVoTRVQBwZNwe6fe5ugDwLNKL7EE8vMkZa1q+3wUw6EbeBjXmP0VRgEUsBNG+ L2ew== X-Gm-Message-State: AOJu0YzKX1Ob3Q+sjmAuXpPf4/zIveERQmIoSw2Ujqp2ZSrGh9VYCWxl ea3eWhSerKM2RHY02gQxF4izoQqsNz40630f9rF2M1PFBCbPmxWpXmzjsG40p6UwfD1X4pdccqQ = X-Gm-Gg: ASbGncu8J//BVw/d2VSBasLxYNixjnTe+yX0GBSP3LgIdQvs/dhyZhYOcoCQC2Rqb4p qgVsiX0ofcKn4hpV9A65PaDHfQ6E+1Fom3kP3nO/sZ+ikXMn/dPqRMCXlEL3JFczrxIsE326nS6 BC1W9g0OvALXUGAUr3g+sxLwxtx+SUqCE+OlWjQLxqnaGAcTKjoldVv9op2qMFun3iNwYDoucrw WPnDOPO50tOA/omeiV6rDPlUIubnLC7e5SioZkGxWh0YlanjjKcqoUEXFuQzoBfzqf6gJJzSZ7Q y7VsIdEX/NqksXVWeIw= X-Google-Smtp-Source: AGHT+IFSuT2+ENL2AFZJMBD75mM9b3DCrYPiGx2+DNGXuCjKQhYTfFJJzw1Pi1HU4HlUFrZS1ojuOQ== X-Received: by 2002:a17:902:ce92:b0:215:e685:fa25 with SMTP id d9443c01a7336-217783b7a08mr70313815ad.20.1733963529631; Wed, 11 Dec 2024 16:32:09 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21680814d6bsm25853825ad.157.2024.12.11.16.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:08 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Date: Wed, 11 Dec 2024 16:31:39 -0800 Message-ID: <20241212003201.2098123-2-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, and the source of a few bugs, such as the one fixed by commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). It's hard to imagine a good reason that these device_match_*() APIs should return 'true' for a NULL argument. Augment these to return 0 (false). Signed-off-by: Brian Norris Reviewed-by: Rob Herring (Arm) Acked-by: Rafael J. Wysocki --- Changes in v2: * Add Rob's Reviewed-by drivers/base/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 94865c9d8adc..2b7b13fc36d7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5246,13 +5246,13 @@ EXPORT_SYMBOL_GPL(device_match_name); int device_match_of_node(struct device *dev, const void *np) { - return dev->of_node == np; + return np && dev->of_node == np; } EXPORT_SYMBOL_GPL(device_match_of_node); int device_match_fwnode(struct device *dev, const void *fwnode) { - return dev_fwnode(dev) == fwnode; + return fwnode && dev_fwnode(dev) == fwnode; } EXPORT_SYMBOL_GPL(device_match_fwnode); @@ -5264,13 +5264,13 @@ EXPORT_SYMBOL_GPL(device_match_devt); int device_match_acpi_dev(struct device *dev, const void *adev) { - return ACPI_COMPANION(dev) == adev; + return adev && ACPI_COMPANION(dev) == adev; } EXPORT_SYMBOL(device_match_acpi_dev); int device_match_acpi_handle(struct device *dev, const void *handle) { - return ACPI_HANDLE(dev) == handle; + return handle && ACPI_HANDLE(dev) == handle; } EXPORT_SYMBOL(device_match_acpi_handle);