| Message ID | 31c6013e-1acd-4d2f-f0d6-baec208ff292@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | pnp: Switch to dev_dbg | expand |
On Thu, May 13, 2021 at 12:25 AM Heiner Kallweit <hkallweit1@gmail.com> wrote: > > Debug output in dmesg log may confuse users. Therefore let's restrict > debug output to cases where DEBUG is defined or dynamic debug output > is enabled for the respective code piece. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/pnp/core.c | 5 ++--- > drivers/pnp/resource.c | 2 +- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c > index ccdfbf397..4df5aa6a3 100644 > --- a/drivers/pnp/core.c > +++ b/drivers/pnp/core.c > @@ -215,9 +215,8 @@ int pnp_add_device(struct pnp_dev *dev) > for (id = dev->id; id; id = id->next) > len += scnprintf(buf + len, sizeof(buf) - len, " %s", id->id); > > - dev_printk(KERN_DEBUG, &dev->dev, "%s device, IDs%s (%s)\n", > - dev->protocol->name, buf, > - dev->active ? "active" : "disabled"); > + dev_dbg(&dev->dev, "%s device, IDs%s (%s)\n", dev->protocol->name, buf, > + dev->active ? "active" : "disabled"); > return 0; > } > > diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c > index 70d4ba957..2fa0f7d55 100644 > --- a/drivers/pnp/resource.c > +++ b/drivers/pnp/resource.c > @@ -540,7 +540,7 @@ struct pnp_resource *pnp_add_irq_resource(struct pnp_dev *dev, int irq, > res->start = irq; > res->end = irq; > > - dev_printk(KERN_DEBUG, &dev->dev, "%pR\n", res); > + dev_dbg(&dev->dev, "%pR\n", res); > return pnp_res; > } > > -- Applied as 5.14 material with edits in the subject and changelog, thanks!
diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c index ccdfbf397..4df5aa6a3 100644 --- a/drivers/pnp/core.c +++ b/drivers/pnp/core.c @@ -215,9 +215,8 @@ int pnp_add_device(struct pnp_dev *dev) for (id = dev->id; id; id = id->next) len += scnprintf(buf + len, sizeof(buf) - len, " %s", id->id); - dev_printk(KERN_DEBUG, &dev->dev, "%s device, IDs%s (%s)\n", - dev->protocol->name, buf, - dev->active ? "active" : "disabled"); + dev_dbg(&dev->dev, "%s device, IDs%s (%s)\n", dev->protocol->name, buf, + dev->active ? "active" : "disabled"); return 0; } diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c index 70d4ba957..2fa0f7d55 100644 --- a/drivers/pnp/resource.c +++ b/drivers/pnp/resource.c @@ -540,7 +540,7 @@ struct pnp_resource *pnp_add_irq_resource(struct pnp_dev *dev, int irq, res->start = irq; res->end = irq; - dev_printk(KERN_DEBUG, &dev->dev, "%pR\n", res); + dev_dbg(&dev->dev, "%pR\n", res); return pnp_res; }
Debug output in dmesg log may confuse users. Therefore let's restrict debug output to cases where DEBUG is defined or dynamic debug output is enabled for the respective code piece. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/pnp/core.c | 5 ++--- drivers/pnp/resource.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-)