From patchwork Sat Jan 17 00:52:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 2911 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0H0rxLP030027 for ; Fri, 16 Jan 2009 16:54:00 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbZAQA5x (ORCPT ); Fri, 16 Jan 2009 19:57:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755189AbZAQA5w (ORCPT ); Fri, 16 Jan 2009 19:57:52 -0500 Received: from mtiwmhc12.worldnet.att.net ([204.127.131.116]:64646 "EHLO mtiwmhc12.worldnet.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754953AbZAQA5v (ORCPT ); Fri, 16 Jan 2009 19:57:51 -0500 X-Greylist: delayed 302 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Jan 2009 19:57:51 EST Received: from [192.168.1.100] (cpe-69-76-240-125.kc.res.rr.com[69.76.240.125]) by worldnet.att.net (mtiwmhc12) with ESMTP id <2009011700524711200di2a4e>; Sat, 17 Jan 2009 00:52:48 +0000 Message-ID: <49712BD8.6060603@lwfinger.net> Date: Fri, 16 Jan 2009 18:52:40 -0600 From: Larry Finger User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Frans Pop CC: Linux Kernel Mailing List , Matthew Garrett , linux-acpi@vger.kernel.org Subject: Re: [regression] hp-wmi: hangs system on boot References: <200901170013.55786.elendil@planet.nl> <200901170131.22541.elendil@planet.nl> In-Reply-To: <200901170131.22541.elendil@planet.nl> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Frans Pop wrote: > On Saturday 17 January 2009, Frans Pop wrote: >> When I first booted .29-rc2 my HP 2510p notebook hung while loading >> hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed. > > Reverting the following commit fixes the problems: > > commit fe8e4e039dc3680681bf51af097af391f87038f8 > Author: Larry Finger > Date: Fri Jan 9 16:40:54 2009 -0800 > > hp-wmi: handle rfkill_register() failure Ooops. There was a missing if statement. This one should fix it. ------- --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/platform/x86/hp-wmi.c =================================================================== --- linux-2.6.orig/drivers/platform/x86/hp-wmi.c +++ linux-2.6/drivers/platform/x86/hp-wmi.c @@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(stru bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set; bluetooth_rfkill->user_claim_unsupported = 1; err = rfkill_register(bluetooth_rfkill); + if (err) goto register_bluetooth_error; }