From patchwork Sat Jan 17 22:50:08 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Starikovskiy X-Patchwork-Id: 2971 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0HMjnMq009992 for ; Sat, 17 Jan 2009 14:45:51 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbZAQWuJ (ORCPT ); Sat, 17 Jan 2009 17:50:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755339AbZAQWuJ (ORCPT ); Sat, 17 Jan 2009 17:50:09 -0500 Received: from mail-bw0-f21.google.com ([209.85.218.21]:49521 "EHLO mail-bw0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755225AbZAQWuH (ORCPT ); Sat, 17 Jan 2009 17:50:07 -0500 Received: by bwz14 with SMTP id 14so6592182bwz.13 for ; Sat, 17 Jan 2009 14:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=hLhxItDZ2qOkQPnDkzN6KcWGO7fUwrSPIiTF98kRFZs=; b=NxCAH0YJlC1h1e8qKI69kAJUUr3L1bqTL3CGP95tdprm6e9HIKcu7G1jlv3g78bAX/ hBwJym1R+Ro9Qi75KsMTc3Qr4Db6m2tLKWBMqCbyIz5fmw2e9E+JvEoSojhuRnIas7VX ue083dYFndPs1em3Px0XCz+zTXWa4lsGDsvhE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=nr9+7f5NnIvtAp8gCRGf/OmU14Pyf7QTymGP8KLjTZyOgT5LWK98ayItjZKdq9VsoE 6GXYPPsIWJMPj4H0N0ECK7aDEM3cnJw6z9yZ99kr4KbZ7+5sZ8H1KE0RNIM73QQB0df7 6UkYu+jraQazotq+w7CES93yy2QFUXviMo4V0= Received: by 10.103.131.18 with SMTP id i18mr778979mun.120.1232232605470; Sat, 17 Jan 2009 14:50:05 -0800 (PST) Received: from ?192.168.101.190? ([81.5.107.78]) by mx.google.com with ESMTPS id y37sm2447764mug.6.2009.01.17.14.50.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Jan 2009 14:50:05 -0800 (PST) Message-ID: <497260A0.6030401@gmail.com> Date: Sun, 18 Jan 2009 01:50:08 +0300 From: Alexey Starikovskiy User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Peter Klotz CC: linux-acpi@vger.kernel.org Subject: Re: ACPI related kernel panic when booting 2.6.29-rc2 References: <497243D5.8000708@aon.at> In-Reply-To: <497243D5.8000708@aon.at> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org please use the patch from Tero Roponen. This patch fixes the crash I experienced in 2.6.29-rc2. Tested on ASUS M50vm. Signed-off-by: Tero Roponen sorry for screw up... Alex Peter Klotz wrote: > On bootup of 2.6.29-rc2 a kernel panic in acpi_ns_get_parent_node occurs. > > This is the backtrace (written down from the screen, maybe incomplete): > > acpi_ev_execute_reg_methods > acpi_install_address_space_handler > acpi_ec_space_handler > acpi_init > ec_install_handlers > acpi_ec_ecdt_probe > acpi_init > fbmem_init > _stext > register_irq_proc > proc_pident_readdir > kernel_init > child_rip > kernel_init > child_rip > > RIP [...] acpi_ns_get_parent_node > > I can provide a screenshot (270kB) if this information is insufficient. > > The system booted with 2.6.29-rc1 so a recent change must be the cause > of this panic. > > The system is an Asus B50A laptop running an x86_64 kernel. > > Maybe this problem is related to these messages I was seeing in > bootups of previous kernels: > > [ 0.176398] ACPI Error (nsaccess-0434): ACPI path has too many > parent prefixes (^) - reached beyond root node [20080926] > > Regards, Peter. > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index a2b82c9..5c2f5d3 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void) saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL); if (!saved_ec) return -ENOMEM; - memcpy(&saved_ec, boot_ec, sizeof(saved_ec)); + memcpy(saved_ec, boot_ec, sizeof(*saved_ec)); /* fall through */ } /* This workaround is needed only on some broken machines,