From patchwork Tue Apr 21 18:01:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 19232 X-Patchwork-Delegate: mjg59@srcf.ucam.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3LI3Nx3017122 for ; Tue, 21 Apr 2009 18:03:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756518AbZDUSBx (ORCPT ); Tue, 21 Apr 2009 14:01:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754931AbZDUSBx (ORCPT ); Tue, 21 Apr 2009 14:01:53 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:63407 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbZDUSBw (ORCPT ); Tue, 21 Apr 2009 14:01:52 -0400 Message-ID: <49EE0A13.50403@dell.com> Date: Tue, 21 Apr 2009 13:01:55 -0500 From: Mario Limonciello User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: mjg59@srcf.ucam.org CC: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] Don't load Dell-WMI on non WMI systems References: <49ECBAE2.2080308@dell.com> In-Reply-To: <49ECBAE2.2080308@dell.com> X-Enigmail-Version: 0.95.7 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi: I've noticed that the dell-wmi module will load on systems even if WMI isn't supported. As this is dependent upon BIOS version, dell-wmi should return -ENODEV in these situations. Regards --- a/drivers/platform/x86/dell-wmi.c~ 2009-04-21 12:41:50.000000000 -0500 +++ b/drivers/platform/x86/dell-wmi.c 2009-04-21 12:30:35.000000000 -0500 @@ -255,8 +255,10 @@ return err; } - } else - printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n"); + } else { + printk(KERN_ERR "dell-wmi: No known WMI GUID found\n"); + return -ENODEV; + } return 0; }