diff mbox

acpi: fix compiler warning in processor_idle.c

Message ID 4AA0E45F02000078000136D5@vpn.id2.novell.com (mailing list archive)
State RFC, archived
Headers show

Commit Message

Jan Beulich Sept. 4, 2009, 7:56 a.m. UTC 
After commit f833bab87fca5c3ce13778421b1365845843b976 a build warning
results when ARCH_APICTIMER_STOPS_ON_C3 is not defined, due to



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

differing prototypes of the two instances of
lapic_timer_propagate_broadcast(). Rather than fixing the stub's
definition, it seems more reasonable to avoid the IPI altogether, since
it's rather pointless to do an IPI for a function that doesn't do
anything (unless the mere side effect of doing having an interrupt
occur on the remote CPU is needed, which doesn't appear to be the case
here).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

---
 drivers/acpi/processor_idle.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.31-rc8/drivers/acpi/processor_idle.c	2009-08-28 14:54:27.000000000 +0200
+++ 2.6.31-rc8-acpi-lapic-timer-propagate/drivers/acpi/processor_idle.c	2009-09-02 12:46:54.000000000 +0200
@@ -193,7 +193,6 @@  static void lapic_timer_state_broadcast(
 
 static void lapic_timer_check_state(int state, struct acpi_processor *pr,
 				   struct acpi_processor_cx *cstate) { }
-static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) { }
 static void lapic_timer_state_broadcast(struct acpi_processor *pr,
 				       struct acpi_processor_cx *cx,
 				       int broadcast)
@@ -636,8 +635,10 @@  static int acpi_processor_power_verify(s
 		working++;
 	}
 
+#ifdef ARCH_APICTIMER_STOPS_ON_C3
 	smp_call_function_single(pr->id, lapic_timer_propagate_broadcast,
 				 pr, 1);
+#endif
 
 	return (working);
 }