From patchwork Fri Sep 4 07:56:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 45585 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n847unr0005799 for ; Fri, 4 Sep 2009 07:56:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279AbZIDH4p (ORCPT ); Fri, 4 Sep 2009 03:56:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932453AbZIDH4p (ORCPT ); Fri, 4 Sep 2009 03:56:45 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:32318 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbZIDH4p convert rfc822-to-8bit (ORCPT ); Fri, 4 Sep 2009 03:56:45 -0400 X-Greylist: delayed 417 seconds by postgrey-1.27 at vger.kernel.org; Fri, 04 Sep 2009 03:56:44 EDT Received: from EMEA1-MTA by vpn.id2.novell.com with Novell_GroupWise; Fri, 04 Sep 2009 08:56:47 +0100 Message-Id: <4AA0E45F02000078000136D5@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.0 Date: Fri, 04 Sep 2009 08:56:47 +0100 From: "Jan Beulich" To: Cc: "Suresh Siddha" , "Venkatesh Pallipadi" , Subject: [PATCH] acpi: fix compiler warning in processor_idle.c Mime-Version: 1.0 Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org After commit f833bab87fca5c3ce13778421b1365845843b976 a build warning results when ARCH_APICTIMER_STOPS_ON_C3 is not defined, due to --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html differing prototypes of the two instances of lapic_timer_propagate_broadcast(). Rather than fixing the stub's definition, it seems more reasonable to avoid the IPI altogether, since it's rather pointless to do an IPI for a function that doesn't do anything (unless the mere side effect of doing having an interrupt occur on the remote CPU is needed, which doesn't appear to be the case here). Signed-off-by: Jan Beulich Cc: Suresh Siddha Cc: Venkatesh Pallipadi --- drivers/acpi/processor_idle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.31-rc8/drivers/acpi/processor_idle.c 2009-08-28 14:54:27.000000000 +0200 +++ 2.6.31-rc8-acpi-lapic-timer-propagate/drivers/acpi/processor_idle.c 2009-09-02 12:46:54.000000000 +0200 @@ -193,7 +193,6 @@ static void lapic_timer_state_broadcast( static void lapic_timer_check_state(int state, struct acpi_processor *pr, struct acpi_processor_cx *cstate) { } -static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) { } static void lapic_timer_state_broadcast(struct acpi_processor *pr, struct acpi_processor_cx *cx, int broadcast) @@ -636,8 +635,10 @@ static int acpi_processor_power_verify(s working++; } +#ifdef ARCH_APICTIMER_STOPS_ON_C3 smp_call_function_single(pr->id, lapic_timer_propagate_broadcast, pr, 1); +#endif return (working); }