| Message ID | 4AABBFD5.1000009@tuffmail.co.uk (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
On Saturday 12 September 2009 09:35:49 am Alan Jenkins wrote: > If an error occurs while binding a driver to a device and we call > remove(), we should also clear acpi->driver and acpi_dev->driverdata. > Otherwise bad things will happen e.g. we will invoke the suspend() > driver callback when the system is suspended, even though the driver > thinks it has been unbound from the device. > > Also check the return value of acpi_start_single_object(). I'm not > sure what will happen if we claim success despite seeing ops.start() > fail and then calling ops.remove(), but it's not a good idea. > > Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> > CC: Bjorn Helgaas <bjorn.helgaas@hp.com> Thanks for fixing this, Alan. I introduced this bug in 46ec8598f. Reviewed-by: Bjorn Helgaas <bjorn.helgaas@hp.com> > --- > drivers/acpi/scan.c | 45 +++++++++++++++++++++++++++------------------ > 1 files changed, 27 insertions(+), 18 deletions(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index 957620b..cde179e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -423,26 +423,33 @@ static int acpi_device_probe(struct device * dev) > int ret; > > ret = acpi_bus_driver_init(acpi_dev, acpi_drv); > - if (!ret) { > - if (acpi_dev->bus_ops.acpi_op_start) > - acpi_start_single_object(acpi_dev); > - > - if (acpi_drv->ops.notify) { > - ret = acpi_device_install_notify_handler(acpi_dev); > - if (ret) { > - if (acpi_drv->ops.remove) > - acpi_drv->ops.remove(acpi_dev, > - acpi_dev->removal_type); > - return ret; > - } > - } > + if (ret) > + return ret; > > - ACPI_DEBUG_PRINT((ACPI_DB_INFO, > - "Found driver [%s] for device [%s]\n", > - acpi_drv->name, acpi_dev->pnp.bus_id)); > - get_device(dev); > + if (acpi_dev->bus_ops.acpi_op_start) { > + ret = acpi_start_single_object(acpi_dev); > + if (ret) > + return ret; > } > - return ret; > + > + if (acpi_drv->ops.notify) { > + ret = acpi_device_install_notify_handler(acpi_dev); > + if (ret) { > + if (acpi_drv->ops.remove) > + acpi_drv->ops.remove(acpi_dev, > + acpi_dev->removal_type); > + acpi_dev->driver = NULL; > + acpi_dev->driver_data = NULL; > + return ret; > + } > + } > + > + ACPI_DEBUG_PRINT((ACPI_DB_INFO, > + "Found driver [%s] for device [%s]\n", > + acpi_drv->name, acpi_dev->pnp.bus_id)); > + get_device(dev); > + > + return 0; > } > > static int acpi_device_remove(struct device * dev) > @@ -617,6 +624,8 @@ static int acpi_start_single_object(struct acpi_device *device) > result = driver->ops.start(device); > if (result && driver->ops.remove) > driver->ops.remove(device, ACPI_BUS_REMOVAL_NORMAL); > + device->driver = NULL; > + device->driver_data = NULL; > } > > return result; -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 957620b..cde179e 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -423,26 +423,33 @@ static int acpi_device_probe(struct device * dev) int ret; ret = acpi_bus_driver_init(acpi_dev, acpi_drv); - if (!ret) { - if (acpi_dev->bus_ops.acpi_op_start) - acpi_start_single_object(acpi_dev); - - if (acpi_drv->ops.notify) { - ret = acpi_device_install_notify_handler(acpi_dev); - if (ret) { - if (acpi_drv->ops.remove) - acpi_drv->ops.remove(acpi_dev, - acpi_dev->removal_type); - return ret; - } - } + if (ret) + return ret; - ACPI_DEBUG_PRINT((ACPI_DB_INFO, - "Found driver [%s] for device [%s]\n", - acpi_drv->name, acpi_dev->pnp.bus_id)); - get_device(dev); + if (acpi_dev->bus_ops.acpi_op_start) { + ret = acpi_start_single_object(acpi_dev); + if (ret) + return ret; } - return ret; + + if (acpi_drv->ops.notify) { + ret = acpi_device_install_notify_handler(acpi_dev); + if (ret) { + if (acpi_drv->ops.remove) + acpi_drv->ops.remove(acpi_dev, + acpi_dev->removal_type); + acpi_dev->driver = NULL; + acpi_dev->driver_data = NULL; + return ret; + } + } + + ACPI_DEBUG_PRINT((ACPI_DB_INFO, + "Found driver [%s] for device [%s]\n", + acpi_drv->name, acpi_dev->pnp.bus_id)); + get_device(dev); + + return 0; } static int acpi_device_remove(struct device * dev) @@ -617,6 +624,8 @@ static int acpi_start_single_object(struct acpi_device *device) result = driver->ops.start(device); if (result && driver->ops.remove) driver->ops.remove(device, ACPI_BUS_REMOVAL_NORMAL); + device->driver = NULL; + device->driver_data = NULL; } return result;
If an error occurs while binding a driver to a device and we call remove(), we should also clear acpi->driver and acpi_dev->driverdata. Otherwise bad things will happen e.g. we will invoke the suspend() driver callback when the system is suspended, even though the driver thinks it has been unbound from the device. Also check the return value of acpi_start_single_object(). I'm not sure what will happen if we claim success despite seeing ops.start() fail and then calling ops.remove(), but it's not a good idea. Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> CC: Bjorn Helgaas <bjorn.helgaas@hp.com> --- drivers/acpi/scan.c | 45 +++++++++++++++++++++++++++------------------ 1 files changed, 27 insertions(+), 18 deletions(-)