From patchwork Mon Oct 5 12:05:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 51735 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n95CDPBL022768 for ; Mon, 5 Oct 2009 12:13:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758558AbZJEMGd (ORCPT ); Mon, 5 Oct 2009 08:06:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758580AbZJEMGd (ORCPT ); Mon, 5 Oct 2009 08:06:33 -0400 Received: from adelie.canonical.com ([91.189.90.139]:45081 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758558AbZJEMGd (ORCPT ); Mon, 5 Oct 2009 08:06:33 -0400 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1MumKB-0003yr-6S; Mon, 05 Oct 2009 13:05:55 +0100 Received: from p5b2e7dde.dip.t-dialin.net ([91.46.125.222] helo=[192.168.2.105]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MumKB-0002eq-0D; Mon, 05 Oct 2009 13:05:55 +0100 Message-ID: <4AC9E122.8050609@canonical.com> Date: Mon, 05 Oct 2009 14:05:54 +0200 From: Stefan Bader User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: lenb@kernel.org, "linux-acpi@vger.kernel.org" , Borislav Petkov , Peter Feuerer Subject: Re: [Fwd: Re: [PATCH] acerhdf: Limit modalias matching to supported boards] References: <4AC9E0F3.5030605@canonical.com> In-Reply-To: <4AC9E0F3.5030605@canonical.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From 60cdb7bea856fdd594262ee1e9608cd2210cf196 Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Mon, 28 Sep 2009 17:11:29 +0000 Subject: [PATCH] acerhdf: Limit modalias matching to supported boards BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958 The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell. Signed-off-by: Stefan Bader Acked-by: Borislav Petkov Acked-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 0a8f735..23eea4c 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void) MODULE_LICENSE("GPL"); MODULE_AUTHOR("Peter Feuerer"); MODULE_DESCRIPTION("Aspire One temperature and fan driver"); -MODULE_ALIAS("dmi:*:*Acer*:*:"); -MODULE_ALIAS("dmi:*:*Gateway*:*:"); -MODULE_ALIAS("dmi:*:*Packard Bell*:*:"); +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:"); +MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:"); +MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:"); +MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:"); module_init(acerhdf_init); module_exit(acerhdf_exit); -- 1.5.4.3