From patchwork Mon Apr 5 13:49:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prarit Bhargava X-Patchwork-Id: 90620 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o35Doa0f010457 for ; Mon, 5 Apr 2010 13:50:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751760Ab0DENuf (ORCPT ); Mon, 5 Apr 2010 09:50:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26143 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107Ab0DENue (ORCPT ); Mon, 5 Apr 2010 09:50:34 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o35Dnsn8028091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Apr 2010 09:49:54 -0400 Received: from [10.16.16.23] (prarit.bos.redhat.com [10.16.16.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o35Dnrvi023965; Mon, 5 Apr 2010 09:49:53 -0400 Message-ID: <4BB9EA81.4080009@redhat.com> Date: Mon, 05 Apr 2010 09:49:53 -0400 From: Prarit Bhargava User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: linux-acpi@vger.kernel.org CC: Bjorn Helgaas , trenn@suse.de, mjg@redhat.com Subject: Re: [RFC PATCH] acpi: Automatically online hot-added memory [v2] References: <20100401131944.4086.82010.sendpatchset@prarit.bos.redhat.com> <201004020931.46783.bjorn.helgaas@hp.com> In-Reply-To: <201004020931.46783.bjorn.helgaas@hp.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 05 Apr 2010 13:50:38 +0000 (UTC) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 93d2c79..dece6bd 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -350,6 +350,14 @@ config ACPI_HOTPLUG_MEMORY To compile this driver as a module, choose M here: the module will be called acpi_memhotplug. +config ACPI_HOTPLUG_MEMORY_AUTO_ONLINE + bool "Automatically online hotplugged memory" + depends on ACPI_HOTPLUG_MEMORY + default n + help + This forces memory that is brought into service by ACPI + to be automatically onlined. + config ACPI_SBS tristate "Smart Battery System" depends on X86 diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index 3597d73..8d40613 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #define ACPI_MEMORY_DEVICE_CLASS "memory" @@ -45,6 +46,11 @@ ACPI_MODULE_NAME("acpi_memhotplug"); MODULE_AUTHOR("Naveen B S "); MODULE_DESCRIPTION("Hotplug Mem Driver"); MODULE_LICENSE("GPL"); +#ifdef CONFIG_ACPI_HOTPLUG_MEMORY_AUTO_ONLINE +static int mem_hotadd_auto = 1; +module_param(mem_hotadd_auto, bool, 0444); +MODULE_PARM_DESC(mem_hotadd_auto, "Disable automatic onlining of memory"); +#endif /* Memory Device States */ #define MEMORY_INVALID_STATE 0 @@ -252,6 +258,20 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) result = add_memory(node, info->start_addr, info->length); if (result) continue; +#ifdef CONFIG_ACPI_HOTPLUG_MEMORY_AUTO_ONLINE + if (mem_hotadd_auto) { + result = online_pages(info->start_addr >> PAGE_SHIFT, + info->length >> PAGE_SHIFT); + if (!result) + set_memory_state(info->start_addr >> PAGE_SHIFT, + info->length >> PAGE_SHIFT, + MEM_ONLINE); + else + printk(KERN_ERR PREFIX "Memory online failed " + "for 0x%llx - 0x%llx\n", info->start_addr, + info->start_addr + info->length); + } +#endif info->enabled = 1; num_enabled++; } diff --git a/drivers/base/memory.c b/drivers/base/memory.c index db0848e..219be91 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -515,6 +515,29 @@ int remove_memory_block(unsigned long node_id, struct mem_section *section, } /* + * need an interface for the VM to mark sections on and offline when + * hot-swapping memory. + */ +void set_memory_state(unsigned long start_pfn, unsigned long nr_pages, + unsigned long state) +{ + struct mem_section *section; + struct memory_block *mem; + unsigned long start_sec, end_sec, i; + + start_sec = pfn_to_section_nr(start_pfn); + end_sec = pfn_to_section_nr(start_pfn + nr_pages - 1); + for (i = start_sec; i <= end_sec; i++) { + if (valid_section_nr(i) && present_section_nr(i)) { + section = __nr_to_section(i); + mem = find_memory_block(section); + mem->state = state; + } + } +} +EXPORT_SYMBOL(set_memory_state); + +/* * need an interface for the VM to add new memory regions, * but without onlining it. */ diff --git a/include/linux/memory.h b/include/linux/memory.h index 85582e1..5735253 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -114,6 +114,7 @@ extern int remove_memory_block(unsigned long, struct mem_section *, int); extern int memory_notify(unsigned long val, void *v); extern int memory_isolate_notify(unsigned long val, void *v); extern struct memory_block *find_memory_block(struct mem_section *); +extern void set_memory_state(unsigned long, unsigned long, unsigned long); #define CONFIG_MEM_BLOCK_SIZE (PAGES_PER_SECTION<